Bug 2184743

Summary: Build fails on Rawhide due to mozbuild breaking on RUSTFLAGS definition containing a comma
Product: [Fedora] Fedora Reporter: Adam Williamson <awilliam>
Component: firefoxAssignee: Gecko Maintainer <gecko-bugs-nobody>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: urgent Docs Contact:
Priority: unspecified    
Version: rawhideCC: erack, gecko-bugs-nobody, jhorak, klaas, pjasicek, rstrode, sandmann
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2023-04-06 16:06:38 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 2184549    

Description Adam Williamson 2023-04-05 15:01:09 UTC 
As discussed at https://bugzilla.redhat.com/show_bug.cgi?id=2184549 , Firefox does not currently build on Rawhide. This is because, on Rawhide, we now have a default definition of RUSTFLAGS. On x86_64, it's this:

RUSTFLAGS='-Copt-level=3 -Cdebuginfo=2 -Ccodegen-units=1 -Cforce-frame-pointers=yes -Clink-arg=-Wl,-z,relro -Clink-arg=-Wl,-z,now --cap-lints=warn'

Unfortunately, mozbuild has a known three-year-old issue that makes it choke on values with commas in them: https://bugzilla.mozilla.org/show_bug.cgi?id=1474486

This makes our builds fail like this:

mozbuild.configure.options.InvalidOptionError: RUSTFLAGS takes 1 value

We either need to fix or workaround the problem in mozbuild, or just unset RUSTFLAGS before running the build (this is how builds in F38 and earlier run - with no explicit RUSTFLAGS - and how the build currently in Rawhide was run, so it wouldn't make things any worse than they are right now).
Comment 1 Adam Williamson 2023-04-05 16:51:28 UTC 
I have a patch for this which seems to be working, at least the scratch build I'm running has survived into the build phase. I'll send an official build with it and we'll see if that gets through.
Comment 2 Adam Williamson 2023-04-05 16:56:27 UTC 
https://koji.fedoraproject.org/koji/taskinfo?taskID=99562740
Comment 3 Adam Williamson 2023-04-05 23:50:33 UTC 
Update: that instafailed because I did a build of 112 to match F38 (my test builds were 111) and 112 needs nss 3.89 and nss 3.89 failed in Rawhide. siiiiigh. So I spent today working on that; I have an nss build running now that I think should work. Will try Firefox again once that's done (if it succeeds).
Comment 4 Adam Williamson 2023-04-06 16:06:38 UTC 
OK, my patch worked, so this is fixed downstream.