Bug 2184743 - Build fails on Rawhide due to mozbuild breaking on RUSTFLAGS definition containing a comma
Summary: Build fails on Rawhide due to mozbuild breaking on RUSTFLAGS definition conta...
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: firefox
Version: rawhide
Hardware: All
OS: Linux
unspecified
urgent
Target Milestone: ---
Assignee: Gecko Maintainer
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 2184549
TreeView+ depends on / blocked
 
Reported: 2023-04-05 15:01 UTC by Adam Williamson
Modified: 2023-04-06 16:06 UTC (History)
7 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2023-04-06 16:06:38 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Mozilla Foundation 1474486 0 -- NEW cannot use comma-separated compiler flags as options value in mozconfig 2023-04-05 15:01:31 UTC

Description Adam Williamson 2023-04-05 15:01:09 UTC
As discussed at https://bugzilla.redhat.com/show_bug.cgi?id=2184549 , Firefox does not currently build on Rawhide. This is because, on Rawhide, we now have a default definition of RUSTFLAGS. On x86_64, it's this:

RUSTFLAGS='-Copt-level=3 -Cdebuginfo=2 -Ccodegen-units=1 -Cforce-frame-pointers=yes -Clink-arg=-Wl,-z,relro -Clink-arg=-Wl,-z,now --cap-lints=warn'

Unfortunately, mozbuild has a known three-year-old issue that makes it choke on values with commas in them: https://bugzilla.mozilla.org/show_bug.cgi?id=1474486

This makes our builds fail like this:

mozbuild.configure.options.InvalidOptionError: RUSTFLAGS takes 1 value

We either need to fix or workaround the problem in mozbuild, or just unset RUSTFLAGS before running the build (this is how builds in F38 and earlier run - with no explicit RUSTFLAGS - and how the build currently in Rawhide was run, so it wouldn't make things any worse than they are right now).

Comment 1 Adam Williamson 2023-04-05 16:51:28 UTC
I have a patch for this which seems to be working, at least the scratch build I'm running has survived into the build phase. I'll send an official build with it and we'll see if that gets through.

Comment 3 Adam Williamson 2023-04-05 23:50:33 UTC
Update: that instafailed because I did a build of 112 to match F38 (my test builds were 111) and 112 needs nss 3.89 and nss 3.89 failed in Rawhide. siiiiigh. So I spent today working on that; I have an nss build running now that I think should work. Will try Firefox again once that's done (if it succeeds).

Comment 4 Adam Williamson 2023-04-06 16:06:38 UTC
OK, my patch worked, so this is fixed downstream.


Note You need to log in before you can comment on or make changes to this bug.