Bug 2187060

Summary:	xorg-x11-drv-fbturbo: Relies on implicit function declarations
Product:	[Fedora] Fedora	Reporter:	Florian Weimer <fweimer>
Component:	xorg-x11-drv-fbturbo	Assignee:	Peter Robinson <pbrobinson>
Status:	CLOSED WONTFIX	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	rawhide	CC:	ajax, pbrobinson
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2023-04-17 08:44:47 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	2137512

Description Florian Weimer 2023-04-16 10:29:38 UTC

Building with future compilers will fail due to implicit function declarations:

fbdev.c:678: implicit function declaration: shadowUpdateRotatePackedWeak
fbdev.c:678: implicit function declaration: shadowUpdatePackedWeak
fbdev.c:982: implicit function declaration: xf86DisableRandR

It's unclear how to fix these properly because these symbol are not defined in Fedora at all. It can only work due to ELF lazy binding and a suitable server configuration which avoids calling these functions.

Comment 1 Florian Weimer 2023-04-16 10:31:23 UTC

Adam, you wrote in 2014 that you “plan to remove the Weak functions from a future server”: <https://cgit.freedesktop.org/xorg/driver/xf86-video-modesetting/commit/?id=d1c6e27759ea1d2c30cabc62ff2bc315bbbec5fc>

Any suggestions how to fix this? Should we just call the non-Weak functions directly? What about xf86DisableRandR, which does not seem to exist at all anymore?

Comment 2 Peter Robinson 2023-04-17 07:24:59 UTC

We can probably just retire this driver, we've been actively moving away from FB based graphics to simpledrm for the last few cycles.

Comment 3 Florian Weimer 2023-04-17 08:11:22 UTC

(In reply to Peter Robinson from comment #2)
> We can probably just retire this driver, we've been actively moving away
> from FB based graphics to simpledrm for the last few cycles.

Oh, that would work for me, too.

Comment 4 Peter Robinson 2023-04-17 08:44:47 UTC

Package now retired in rawhide/F-39.

Comment 5 Florian Weimer 2023-04-17 08:57:57 UTC

(In reply to Peter Robinson from comment #4)
> Package now retired in rawhide/F-39.

Any idea when this will become visible in dist-git? Thanks.

Comment 6 Peter Robinson 2023-04-17 09:27:20 UTC

> Any idea when this will become visible in dist-git? Thanks.

There's some issue with the retire process when using "fedpkg retire" I've filed an issue here:

https://pagure.io/releng/issue/11388