Bug 2187060 - xorg-x11-drv-fbturbo: Relies on implicit function declarations
Summary: xorg-x11-drv-fbturbo: Relies on implicit function declarations
Keywords:
Status: CLOSED WONTFIX
Alias: None
Product: Fedora
Classification: Fedora
Component: xorg-x11-drv-fbturbo
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Peter Robinson
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: PortingToModernCHelpNeeded
TreeView+ depends on / blocked
 
Reported: 2023-04-16 10:29 UTC by Florian Weimer
Modified: 2023-04-17 09:27 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2023-04-17 08:44:47 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description Florian Weimer 2023-04-16 10:29:38 UTC
Building with future compilers will fail due to implicit function declarations:

fbdev.c:678: implicit function declaration: shadowUpdateRotatePackedWeak
fbdev.c:678: implicit function declaration: shadowUpdatePackedWeak
fbdev.c:982: implicit function declaration: xf86DisableRandR

It's unclear how to fix these properly because these symbol are not defined in Fedora at all. It can only work due to ELF lazy binding and a suitable server configuration which avoids calling these functions.

Comment 1 Florian Weimer 2023-04-16 10:31:23 UTC
Adam, you wrote in 2014 that you “plan to remove the Weak functions from a future server”: <https://cgit.freedesktop.org/xorg/driver/xf86-video-modesetting/commit/?id=d1c6e27759ea1d2c30cabc62ff2bc315bbbec5fc>

Any suggestions how to fix this? Should we just call the non-Weak functions directly? What about xf86DisableRandR, which does not seem to exist at all anymore?

Comment 2 Peter Robinson 2023-04-17 07:24:59 UTC
We can probably just retire this driver, we've been actively moving away from FB based graphics to simpledrm for the last few cycles.

Comment 3 Florian Weimer 2023-04-17 08:11:22 UTC
(In reply to Peter Robinson from comment #2)
> We can probably just retire this driver, we've been actively moving away
> from FB based graphics to simpledrm for the last few cycles.

Oh, that would work for me, too.

Comment 4 Peter Robinson 2023-04-17 08:44:47 UTC
Package now retired in rawhide/F-39.

Comment 5 Florian Weimer 2023-04-17 08:57:57 UTC
(In reply to Peter Robinson from comment #4)
> Package now retired in rawhide/F-39.

Any idea when this will become visible in dist-git? Thanks.

Comment 6 Peter Robinson 2023-04-17 09:27:20 UTC
> Any idea when this will become visible in dist-git? Thanks.

There's some issue with the retire process when using "fedpkg retire" I've filed an issue here:

https://pagure.io/releng/issue/11388


Note You need to log in before you can comment on or make changes to this bug.