Bug 2187168

Summary: star: Build in C89 mode
Product: [Fedora] Fedora Reporter: Florian Weimer <fweimer>
Component: starAssignee: Ondrej Vasik <ovasik>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: unspecified    
Version: rawhideCC: ovasik, praiskup
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Linux   
Whiteboard:
Fixed In Version: star-1.6-9.fc39 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2023-04-17 07:14:47 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 2137516    
Attachments:
Description Flags
star-configure-c99.patch
none
config.guess fix none

Description Florian Weimer 2023-04-17 06:37:59 UTC 
The configure script has many C89isms in it, so the package will not build correctly with future compilers. Given the unclear upstream state, I prefer not to spend efforts on fixing this, and we should build star in C89 mode.

config.guess runs the compiler without passing any flags, so that part at least needs to be fixed.

Reproducible: Always
Comment 1 Florian Weimer 2023-04-17 06:38:59 UTC 
Created attachment 1957788 [details]
star-configure-c99.patch

config.guess fix
Comment 2 Florian Weimer 2023-04-17 06:58:41 UTC 
Created attachment 1957789 [details]
config.guess fix

Smaller patch.