Bug 2187168 - star: Build in C89 mode
Summary: star: Build in C89 mode
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: star
Version: rawhide
Hardware: Unspecified
OS: Linux
unspecified
medium
Target Milestone: ---
Assignee: Ondrej Vasik
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: PortingToModernCExemptions
TreeView+ depends on / blocked
 
Reported: 2023-04-17 06:37 UTC by Florian Weimer
Modified: 2024-01-29 12:00 UTC (History)
2 users (show)

Fixed In Version: star-1.6-13.fc40
Clone Of:
Environment:
Last Closed: 2023-04-17 07:14:47 UTC
Type: ---
Embargoed:
fweimer: mirror+

Attachments (Terms of Use)
star-configure-c99.patch (5.57 KB, patch)
2023-04-17 06:38 UTC, Florian Weimer 		no flags Details | Diff
config.guess fix (658 bytes, patch)
2023-04-17 06:58 UTC, Florian Weimer 		no flags Details | Diff
Another fix attempt (44.14 KB, patch)
2024-01-29 11:31 UTC, Florian Weimer 		no flags Details | Diff
Show Obsolete (1) View All


Links
System ID Private Priority Status Summary Last Updated
Red Hat Issue Tracker FC-1093 0 None None None 2024-01-29 11:32:26 UTC

Description Florian Weimer 2023-04-17 06:37:59 UTC 
The configure script has many C89isms in it, so the package will not build correctly with future compilers. Given the unclear upstream state, I prefer not to spend efforts on fixing this, and we should build star in C89 mode.

config.guess runs the compiler without passing any flags, so that part at least needs to be fixed.

Reproducible: Always
Comment 1 Florian Weimer 2023-04-17 06:38:59 UTC 
Created attachment 1957788 [details]
star-configure-c99.patch

config.guess fix
Comment 2 Florian Weimer 2023-04-17 06:58:41 UTC 
Created attachment 1957789 [details]
config.guess fix

Smaller patch.
Comment 3 Florian Weimer 2024-01-29 11:31:57 UTC 
Created attachment 2011364 [details]
Another fix attempt

I tried once more to fix this, but it's really not possible.
Comment 4 Florian Weimer 2024-01-29 12:00:24 UTC 
I spent quite a bit of time to find this fix for the missing build flags injection on i686:

-for PLAT in %{arm} %{power64} aarch64 %{mips} x86_64 s390 s390x sh3 sh4 sh4a sparcv9; do
+for PLAT in %{arm} %{power64} aarch64 i686 %{mips} x86_64 s390 s390x sh3 sh4 sh4a sparcv9; do
Note You need to log in before you can comment on or make changes to this bug.