Bug 2187524
| Summary: | cnv storage components are missing required metadata.labels | ||
|---|---|---|---|
| Product: | Container Native Virtualization (CNV) | Reporter: | Debarati Basu-Nag <dbasunag> |
| Component: | Storage | Assignee: | Alex Kalenyuk <akalenyu> |
| Status: | CLOSED ERRATA | QA Contact: | Harel Meir <hmeir> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | 4.13.0 | CC: | akalenyu, alitke, dafrank, yadu |
| Target Milestone: | --- | ||
| Target Release: | 4.14.0 | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | CNV v4.14.0.rhel9-1724 | Doc Type: | If docs needed, set a value |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2023-11-08 14:05:28 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Comment 1
Adam Litke
2023-06-30 15:25:09 UTC
Sure Note some of these are not created by us, and some others are waiting on an OLM issue, More information can be found here: https://bugzilla.redhat.com/show_bug.cgi?id=1994389#c3 Also note that for KubeVirt we only ever implemented these labels on operator-created resources: https://github.com/kubevirt/kubevirt/pull/3875 So there should be an epic somewhere about applying these to workloads like the virt-launcher pod, for example. I will take a look at submitting PRs for the others (In reply to Alex Kalenyuk from comment #2) > Sure > > Note some of these are not created by us, and some others are waiting on an > OLM issue, > More information can be found here: > https://bugzilla.redhat.com/show_bug.cgi?id=1994389#c3 > > Also note that for KubeVirt we only ever implemented these labels on > operator-created resources: > https://github.com/kubevirt/kubevirt/pull/3875 > So there should be an epic somewhere about applying these to workloads like > the virt-launcher pod, for example. > > I will take a look at submitting PRs for the others Following up on this, created an HPP PR for the missing resources that we actually manage. Note leases, CSIStorageCapacity, and PodMetrics are not created/managed by us. Verified on 4.14.0:
Checked that for relevant resourced (according to alex notes - like hpp-pool pods, replicasets etc) the required labels appears.
for example for hpp-pool pods:
labels:
app.kubernetes.io/component: storage
app.kubernetes.io/managed-by: hostpath-provisioner-operator
app.kubernetes.io/part-of: hyperconverged-cluster
app.kubernetes.io/version: 4.14.0
hpp-pool: hpp-csi-pvc-block-hpp
k8s-app: hostpath-provisioner
kubevirt.io.hostpath-provisioner/storagePool: hpp-csi-pvc-block-hpp
Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory (Important: OpenShift Virtualization 4.14.0 Images security and bug fix update), and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://access.redhat.com/errata/RHSA-2023:6817 |