Bug 2187524 - cnv storage components are missing required metadata.labels
Summary: cnv storage components are missing required metadata.labels
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Container Native Virtualization (CNV)
Classification: Red Hat
Component: Storage
Version: 4.13.0
Hardware: Unspecified
OS: Unspecified
medium
medium
Target Milestone: ---
: 4.14.0
Assignee: Alex Kalenyuk
QA Contact: Harel Meir
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2023-04-17 20:01 UTC by Debarati Basu-Nag
Modified: 2023-11-08 14:05 UTC (History)
4 users (show)

Fixed In Version: CNV v4.14.0.rhel9-1724
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2023-11-08 14:05:28 UTC
Target Upstream Version:
Embargoed:

Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Github kubevirt hostpath-provisioner-operator pull 364 0 None Merged Add relationship labels to pods created by storage pool 2023-08-24 09:26:50 UTC
Github kubevirt hostpath-provisioner-operator pull 366 0 None Merged [release-v0.16] Add relationship labels to pods created by storage pool 2023-08-24 09:26:50 UTC
Red Hat Issue Tracker CNV-28183 0 None None None 2023-04-17 20:05:13 UTC
Red Hat Product Errata RHSA-2023:6817 0 None None None 2023-11-08 14:05:42 UTC

Comment 1 Adam Litke 2023-06-30 15:25:09 UTC 
Hi Alex.  Can we try to get this resolved for 4.14.0 please?
Comment 2 Alex Kalenyuk 2023-07-02 14:53:35 UTC 
Sure

Note some of these are not created by us, and some others are waiting on an OLM issue,
More information can be found here:
https://bugzilla.redhat.com/show_bug.cgi?id=1994389#c3

Also note that for KubeVirt we only ever implemented these labels on operator-created resources:
https://github.com/kubevirt/kubevirt/pull/3875
So there should be an epic somewhere about applying these to workloads like the virt-launcher pod, for example.

I will take a look at submitting PRs for the others
Comment 3 Alex Kalenyuk 2023-08-24 09:26:51 UTC 
(In reply to Alex Kalenyuk from comment #2)
> Sure
> 
> Note some of these are not created by us, and some others are waiting on an
> OLM issue,
> More information can be found here:
> https://bugzilla.redhat.com/show_bug.cgi?id=1994389#c3
> 
> Also note that for KubeVirt we only ever implemented these labels on
> operator-created resources:
> https://github.com/kubevirt/kubevirt/pull/3875
> So there should be an epic somewhere about applying these to workloads like
> the virt-launcher pod, for example.
> 
> I will take a look at submitting PRs for the others

Following up on this, created an HPP PR for the missing resources that we actually manage.
Note leases, CSIStorageCapacity, and PodMetrics are not created/managed by us.
Comment 4 Harel Meir 2023-08-30 11:33:41 UTC 
Verified on 4.14.0:

Checked that for relevant resourced (according to alex notes - like hpp-pool pods, replicasets etc) the required labels appears.
for example for hpp-pool pods:

 labels:
    app.kubernetes.io/component: storage
    app.kubernetes.io/managed-by: hostpath-provisioner-operator
    app.kubernetes.io/part-of: hyperconverged-cluster
    app.kubernetes.io/version: 4.14.0
    hpp-pool: hpp-csi-pvc-block-hpp
    k8s-app: hostpath-provisioner
    kubevirt.io.hostpath-provisioner/storagePool: hpp-csi-pvc-block-hpp
Comment 6 errata-xmlrpc 2023-11-08 14:05:28 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Important: OpenShift Virtualization 4.14.0 Images security and bug fix update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2023:6817
Note You need to log in before you can comment on or make changes to this bug.