Bug 2188539

Summary:	Review Request: <python-closure> - <tool for reducing the size of JavaScript files>
Product:	[Fedora] Fedora	Reporter:	Soumil <soumilkadam>
Component:	Package Review	Assignee:	Nobody's working on this, feel free to take it <nobody>
Status:	CLOSED NOTABUG	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	unspecified
Version:	rawhide	CC:	package-review, zbyszek
Target Milestone:	---
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2024-06-12 00:45:35 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	201449

Description Soumil 2023-04-21 05:01:18 UTC

Spec URL: <https://github.com/Soumil28/python-closure/blob/main/python-closure.spec>
SRPM URL: <https://github.com/Soumil28/python-closure/blob/main/python-closure-20191111-1.fc36.src.rpm>
Description: <a tool to reduce the size of JavaScript files to make them download and run faster>
Fedora Account System Username: soumil
Comments: New user, student.

Comment 1 Zbigniew Jędrzejewski-Szmek 2023-05-13 13:41:08 UTC

Please remove the quotes (<>).
%description has stray quote marks too and run-together words and seems to
end in the middle of a sentence.

The license is specified using obsolete notation. Now SPDX must be used:
https://docs.fedoraproject.org/en-US/packaging-guidelines/LicensingGuidelines/#_valid_license_short_names

Please use rpmautospec:
https://docs.fedoraproject.org/en-US/packaging-guidelines/#changelogs
https://docs.fedoraproject.org/en-US/packaging-guidelines/Versioning/#_release_tag

Instead of repeating the description two times, use the following:
%global _description %{expand:
<description here>}

%description _description

%description -n python3-%{pypi_name} %_description

Comment 2 Zbigniew Jędrzejewski-Szmek 2023-05-13 13:49:50 UTC

This review request seems to be one in a series of semi-serious review requests
made using automatic packaging generators. The Fedora review process is not an
appropriate channel to learn about packaging, unless you actually intend to
have the packages in Fedora and maintain them over time. I closed the other two.

Comment 3 Package Review 2024-05-13 00:45:27 UTC

This is an automatic check from review-stats script.

This review request ticket hasn't been updated for some time. We're sorry
it is taking so long. If you're still interested in packaging this software
into Fedora repositories, please respond to this comment clearing the
NEEDINFO flag.

You may want to update the specfile and the src.rpm to the latest version
available and to propose a review swap on Fedora devel mailing list to increase
chances to have your package reviewed. If this is your first package and you
need a sponsor, you may want to post some informal reviews. Read more at
https://fedoraproject.org/wiki/How_to_get_sponsored_into_the_packager_group.

Without any reply, this request will shortly be considered abandoned
and will be closed.
Thank you for your patience.

Comment 4 Package Review 2024-06-12 00:45:35 UTC

This is an automatic action taken by review-stats script.

The ticket submitter failed to clear the NEEDINFO flag in a month.
As per https://fedoraproject.org/wiki/Policy_for_stalled_package_reviews
we consider this ticket as DEADREVIEW and proceed to close it.