Bug 2188539 - Review Request: <python-closure> - <tool for reducing the size of JavaScript files>
Summary: Review Request: <python-closure> - <tool for reducing the size of JavaScript ...
Keywords:
Status: CLOSED NOTABUG
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
unspecified
medium
Target Milestone: ---
Assignee: Nobody's working on this, feel free to take it
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: FE-DEADREVIEW
TreeView+ depends on / blocked
 
Reported: 2023-04-21 05:01 UTC by Soumil
Modified: 2024-06-12 00:45 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2024-06-12 00:45:35 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Bugzilla 2181934 0 unspecified CLOSED Review Request: <hello> - <GNU Hello World Package> 2023-05-13 13:48:01 UTC
Red Hat Bugzilla 2185512 0 unspecified CLOSED Review Request: <python-setuptools> - <a package useful to build other python packages> 2023-05-13 13:48:01 UTC

Description Soumil 2023-04-21 05:01:18 UTC
Spec URL: <https://github.com/Soumil28/python-closure/blob/main/python-closure.spec>
SRPM URL: <https://github.com/Soumil28/python-closure/blob/main/python-closure-20191111-1.fc36.src.rpm>
Description: <a tool to reduce the size of JavaScript files to make them download and run faster>
Fedora Account System Username: soumil
Comments: New user, student.

Comment 1 Zbigniew Jędrzejewski-Szmek 2023-05-13 13:41:08 UTC
Please remove the quotes (<>).
%description has stray quote marks too and run-together words and seems to
end in the middle of a sentence.

The license is specified using obsolete notation. Now SPDX must be used:
https://docs.fedoraproject.org/en-US/packaging-guidelines/LicensingGuidelines/#_valid_license_short_names

Please use rpmautospec:
https://docs.fedoraproject.org/en-US/packaging-guidelines/#changelogs
https://docs.fedoraproject.org/en-US/packaging-guidelines/Versioning/#_release_tag

Instead of repeating the description two times, use the following:
%global _description %{expand:
<description here>}

%description _description

%description -n python3-%{pypi_name} %_description

Comment 2 Zbigniew Jędrzejewski-Szmek 2023-05-13 13:49:50 UTC
This review request seems to be one in a series of semi-serious review requests
made using automatic packaging generators. The Fedora review process is not an
appropriate channel to learn about packaging, unless you actually intend to
have the packages in Fedora and maintain them over time. I closed the other two.

Comment 3 Package Review 2024-05-13 00:45:27 UTC
This is an automatic check from review-stats script.

This review request ticket hasn't been updated for some time. We're sorry
it is taking so long. If you're still interested in packaging this software
into Fedora repositories, please respond to this comment clearing the
NEEDINFO flag.

You may want to update the specfile and the src.rpm to the latest version
available and to propose a review swap on Fedora devel mailing list to increase
chances to have your package reviewed. If this is your first package and you
need a sponsor, you may want to post some informal reviews. Read more at
https://fedoraproject.org/wiki/How_to_get_sponsored_into_the_packager_group.

Without any reply, this request will shortly be considered abandoned
and will be closed.
Thank you for your patience.

Comment 4 Package Review 2024-06-12 00:45:35 UTC
This is an automatic action taken by review-stats script.

The ticket submitter failed to clear the NEEDINFO flag in a month.
As per https://fedoraproject.org/wiki/Policy_for_stalled_package_reviews
we consider this ticket as DEADREVIEW and proceed to close it.


Note You need to log in before you can comment on or make changes to this bug.