Bug 2188541

Summary:	Review Request: <python-cssmin> - <a python port of the YUI CSS compression algorithm>
Product:	[Fedora] Fedora	Reporter:	Soumil <soumilkadam>
Component:	Package Review	Assignee:	Nobody's working on this, feel free to take it <nobody>
Status:	CLOSED DUPLICATE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	unspecified
Version:	rawhide	CC:	fedora, package-review
Target Milestone:	---
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2023-04-23 11:34:48 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Soumil 2023-04-21 05:30:30 UTC

Spec URL: <https://github.com/Soumil28/python-cssmin/blob/main/python-cssmin.spec>
SRPM URL: <https://github.com/Soumil28/python-cssmin/blob/main/python-cssmin-0.2.0-1.fc36.src.rpm>
Description: <a python port of the YUI CSS compression algorithm>
Fedora Account System Username: soumil
Comments: New user, student. Original link 'https://pypi.org/project/cssmin/'

Comment 1 Artur Frenszek-Iwicki 2023-04-23 11:34:48 UTC

> Spec URL: <https://github.com/Soumil28/python-cssmin/blob/main/python-cssmin.spec>
1. Post the links as "link", not "<link>". The submission template uses "<thing>" to mean "placeholder".
   Same for the bug title.
2. This link leads to a syntax-highlighted, HTML rendition of the file. Please use "raw file" links.

> # Check if the automatically generated License and its spelling is correct for Fedora
> # https://docs.fedoraproject.org/en-US/packaging-guidelines/LicensingGuidelines/
> License:        UNKNOWN
> [...]
> # Fill in the actual package description to submit package to Fedora
> %global _description %{expand:
> This is package 'cssmin' generated automatically by pyp2spec.}
> [...]
> # For official Fedora packages, including files with '*' +auto is not allowed
> # Replace it with a list of relevant Python modules/globs and list extra files in %%files
> %pyproject_save_files '*' +auto
Sorry, but looking at these, I get the impression you just used py2rpm and didn't bother
looking at the generated files to try and make them fit the Packaging Guidelines.
https://docs.fedoraproject.org/en-US/packaging-guidelines/

All of the points above don't really matter, though, because python-cssmin is already available in Fedora:
https://src.fedoraproject.org/rpms/python-cssmin

*** This bug has been marked as a duplicate of bug 1014601 ***