Bug 2188541 - Review Request: <python-cssmin> - <a python port of the YUI CSS compression algorithm>
Summary: Review Request: <python-cssmin> - <a python port of the YUI CSS compression a...
Keywords:
Status: CLOSED DUPLICATE of bug 1014601
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
unspecified
medium
Target Milestone: ---
Assignee: Nobody's working on this, feel free to take it
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2023-04-21 05:30 UTC by Soumil
Modified: 2023-04-23 11:34 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2023-04-23 11:34:48 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)

Description Soumil 2023-04-21 05:30:30 UTC
Spec URL: <https://github.com/Soumil28/python-cssmin/blob/main/python-cssmin.spec>
SRPM URL: <https://github.com/Soumil28/python-cssmin/blob/main/python-cssmin-0.2.0-1.fc36.src.rpm>
Description: <a python port of the YUI CSS compression algorithm>
Fedora Account System Username: soumil
Comments: New user, student. Original link 'https://pypi.org/project/cssmin/'

Comment 1 Artur Frenszek-Iwicki 2023-04-23 11:34:48 UTC
> Spec URL: <https://github.com/Soumil28/python-cssmin/blob/main/python-cssmin.spec>
1. Post the links as "link", not "<link>". The submission template uses "<thing>" to mean "placeholder".
   Same for the bug title.
2. This link leads to a syntax-highlighted, HTML rendition of the file. Please use "raw file" links.

> # Check if the automatically generated License and its spelling is correct for Fedora
> # https://docs.fedoraproject.org/en-US/packaging-guidelines/LicensingGuidelines/
> License:        UNKNOWN
> [...]
> # Fill in the actual package description to submit package to Fedora
> %global _description %{expand:
> This is package 'cssmin' generated automatically by pyp2spec.}
> [...]
> # For official Fedora packages, including files with '*' +auto is not allowed
> # Replace it with a list of relevant Python modules/globs and list extra files in %%files
> %pyproject_save_files '*' +auto
Sorry, but looking at these, I get the impression you just used py2rpm and didn't bother
looking at the generated files to try and make them fit the Packaging Guidelines.
https://docs.fedoraproject.org/en-US/packaging-guidelines/

All of the points above don't really matter, though, because python-cssmin is already available in Fedora:
https://src.fedoraproject.org/rpms/python-cssmin

*** This bug has been marked as a duplicate of bug 1014601 ***


Note You need to log in before you can comment on or make changes to this bug.