Bug 2193070

Summary: python-bitcoinlib fails to build with Python 3.12: bitcoin.core.script.CScriptTruncatedPushDataError: PUSHDATA(1): truncated data
Product: [Fedora] Fedora Reporter: Tomáš Hrnčiar <thrnciar>
Component: python-bitcoinlibAssignee: Pablo Greco <pablo>
Status: NEW --- QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 39CC: cstratak, mhroncok, pablo, thrnciar
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 2135404    

Description Tomáš Hrnčiar 2023-05-04 08:28:08 UTC
python-bitcoinlib fails to build with Python 3.12.0a7.

======================================================================
ERROR: test_has_canonical_pushes_with_invalid_truncated_script (bitcoin.tests.test_script.Test_CScript.test_has_canonical_pushes_with_invalid_truncated_script)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/builddir/build/BUILD/python-bitcoinlib-0.12.0/bitcoin/tests/test_script.py", line 376, in test_has_canonical_pushes_with_invalid_truncated_script
    T('01')
  File "/builddir/build/BUILD/python-bitcoinlib-0.12.0/bitcoin/tests/test_script.py", line 374, in T
    self.assertEqual(script.has_canonical_pushes(), False)
                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/builddir/build/BUILD/python-bitcoinlib-0.12.0/bitcoin/core/script.py", line 754, in has_canonical_pushes
    return False
           ^^^^^
  File "/builddir/build/BUILD/python-bitcoinlib-0.12.0/bitcoin/core/script.py", line 606, in raw_iter
    raise CScriptTruncatedPushDataError('%s: truncated data' % pushdata_type, data)
bitcoin.core.script.CScriptTruncatedPushDataError: PUSHDATA(1): truncated data

======================================================================
ERROR: test_is_push_only_on_invalid_pushdata (bitcoin.tests.test_script.Test_CScript.test_is_push_only_on_invalid_pushdata)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/builddir/build/BUILD/python-bitcoinlib-0.12.0/bitcoin/tests/test_script.py", line 310, in test_is_push_only_on_invalid_pushdata
    T('01')
  File "/builddir/build/BUILD/python-bitcoinlib-0.12.0/bitcoin/tests/test_script.py", line 308, in T
    self.assertFalse(invalid_script.is_push_only())
                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/builddir/build/BUILD/python-bitcoinlib-0.12.0/bitcoin/core/script.py", line 724, in is_push_only
    return False
           ^^^^^
  File "/builddir/build/BUILD/python-bitcoinlib-0.12.0/bitcoin/core/script.py", line 606, in raw_iter
    raise CScriptTruncatedPushDataError('%s: truncated data' % pushdata_type, data)
bitcoin.core.script.CScriptTruncatedPushDataError: PUSHDATA(1): truncated data

https://docs.python.org/3.12/whatsnew/3.12.html

For the build logs, see:
https://copr-be.cloud.fedoraproject.org/results/@python/python3.12/fedora-rawhide-x86_64/05839068-python-bitcoinlib/

For all our attempts to build python-bitcoinlib with Python 3.12, see:
https://copr.fedorainfracloud.org/coprs/g/python/python3.12/package/python-bitcoinlib/

Testing and mass rebuild of packages is happening in copr. You can follow these instructions to test locally in mock if your package builds with Python 3.12:
https://copr.fedorainfracloud.org/coprs/g/python/python3.12/

Let us know here if you have any questions.

Python 3.12 is planned to be included in Fedora 39. To make that update smoother, we're building Fedora packages with all pre-releases of Python 3.12.
A build failure prevents us from testing all dependent packages (transitive [Build]Requires), so if this package is required a lot, it's important for us to get it fixed soon.
We'd appreciate help from the people who know this package best, but if you don't want to work on this now, let us know so we can try to work around it on our side.

Comment 1 Fedora Release Engineering 2023-08-16 07:13:56 UTC
This bug appears to have been reported against 'rawhide' during the Fedora Linux 39 development cycle.
Changing version to 39.