Bug 219731

Summary: need a way to disable brp-java-repack-jars
Product: Red Hat Enterprise Linux 5 Reporter: Thomas Fitzsimmons <fitzsim>
Component: redhat-rpm-configAssignee: Jon Masters <jcm>
Status: CLOSED DUPLICATE QA Contact: David Lawrence <dkl>
Severity: medium Docs Contact:
Priority: medium    
Version: 5.0CC: caolanm, frank, patrickm
Target Milestone: ---Keywords: Reopened
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2009-12-01 05:52:21 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Thomas Fitzsimmons 2006-12-14 23:42:50 UTC
For the proprietary JDK packages I'd like a way to cleanly disable repacking
jars.  (For various reasons, we install the JDK jars under /usr/lib, in
arch-specific directories, so there is no need to adjust their contents'
timestamps).  I could use a hack like this:

# HACK: disable brp-java-repack-jars
%define __os_install_post    \
    /usr/lib/rpm/redhat/brp-compress \
    %{!?__debug_package:/usr/lib/rpm/redhat/brp-strip %{__strip}} \
    /usr/lib/rpm/redhat/brp-strip-static-archive %{__strip} \
    /usr/lib/rpm/redhat/brp-strip-comment-note %{__strip} %{__objdump} \
    /usr/lib/rpm/brp-python-bytecompile \
%{nil}

but I would prefer something like:

%define _disable_jar_repacking 1

where %__os_install_post would contain:

...
    %{!?_disable_jar_repacking:/usr/lib/rpm/redhat/brp-java-repack-jars} \
...

Comment 1 Jeremy Katz 2007-06-19 18:30:17 UTC
Will be in the next version of redhat-rpm-config; if you want it backported for
RHEL5, reopen

Mechanism to disable is
  %define __jar_repack 0
in the spec file

Comment 2 Thomas Fitzsimmons 2007-06-29 18:08:35 UTC
I would like this backported to RHEL-5 so that I can avoid repack attempts on
signed jars in the JDK packages.


Comment 3 Thomas Fitzsimmons 2007-06-29 19:05:06 UTC
I have found a way to avoid running brp-java-repack-jars, by adding:

%define __os_install_post %{nil}

at the top of the spec file but it would be preferable to disable only the jar
repacking script.


Comment 4 Red Hat Bugzilla 2008-07-25 01:03:52 UTC
Adding patrickm to the cc list as the manager of the disabled user fitzsim who reported this bug

Comment 5 Jeremy West 2009-04-22 02:15:06 UTC
Thomas and Jeremy,

We've had a similar RFE filed by Nortel:
https://bugzilla.redhat.com/show_bug.cgi?id=497011

I intentially filed that bug as it's asking for a more generic way to disable not just brp-java-repack-jars, but also brp-python-bytecompile.  Should we close this one as a dup?

--jwest

Comment 6 Caolan McNamara 2009-11-18 10:20:52 UTC
My efforts to backport OOo 3.1.1 to RHEL-5 also re-trigger the problem of
https://bugzilla.redhat.com/show_bug.cgi?id=465664
i.e. reordering the order of MANIFEST.MF in the .jar file -> no help search available, where the only fix is to disable the jar repacking, which is hard in RHEL-5

Comment 7 Jon Masters 2009-12-01 05:52:21 UTC

*** This bug has been marked as a duplicate of bug 497011 ***

Comment 8 Frank Ederveen 2013-04-05 12:05:50 UTC
Marking bugs as duplicate of another bug which is not visible outside RedHat is not very useful.

You are not authorized to access bug #497011.