Bug 219978
| Summary: | Review Request: thunar-media-tags-plugin - Media Tags plugin for the Thunar file manager | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Christoph Wickert <christoph.wickert> |
| Component: | Package Review | Assignee: | Kevin Fenzi <kevin> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Package Reviews List <fedora-package-review> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | ||
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2007-01-02 18:32:48 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 163779 | ||
|
Description
Christoph Wickert
2006-12-18 02:10:14 UTC
I'd be happy to review this package...
Look for a full review in a bit.
> Note: ATM %{_libdir}/thunarx-1/ is not owned by any package, but this is a bug
in Thunar. I already informed Kevin about this.
Yeah, sorry about that. I have the fix queued up... it should go out with the
next update to Thunar.
See below - Package meets naming and packaging guidelines OK - Spec file matches base package name. OK - Spec has consistant macro usage. OK - Meets Packaging Guidelines. OK - License(GPL) OK - License field in spec matches OK - License file included in package OK - Spec in American English OK - Spec is legible. OK - Sources match upstream md5sum: 1535da390f7e26350e9bff1a5bc3cdae thunar-media-tags-plugin-0.1.1.tar.bz2 1535da390f7e26350e9bff1a5bc3cdae thunar-media-tags-plugin-0.1.1.tar.bz2.1 OK - BuildRequires correct OK - Spec handles locales/find_lang OK - Package has %defattr and permissions on files is good. OK - Package has a correct %clean section. OK - Package has correct buildroot OK - Package is code or permissible content. OK - Packages %doc files don't affect runtime. OK - Package compiles and builds on at least one arch. OK - Package has no duplicate files in %files. OK - Package doesn't own any directories other packages own. OK - Package owns all the directories it creates. OK - No rpmlint output. OK - final provides and requires are sane SHOULD Items: OK - Should build in mock. i386/x86_64 - Should build on all supported archs OK - Should function as described. OK - Should have dist tag OK - Should package latest version Issues: 1. Should the name of this package have a capital T ? ie, thunar-media-tags-plugin should be Thunar-media-tags-plugin Since the Thunar package uses a uppercase T? Otherwise I see no blockers or issues, so this package is APPROVED. If you do decide to change it to use a uppercase T, also do change the summary of this bug so the package is tracked properly. Don't forget to close this package review NEXTRELEASE once it's been imported and built. (In reply to comment #2) > > 1. Should the name of this package have a capital T ? I don't think so. Yes, Thunar has a capital T, but in case of Thunar * source has capital T * the binary has capital T * lowercase "thunar" is only a symlink to capital Thunar In case of this package we have * lowercase source * lowercase lib %{name}.so * lowercase locales %{name}.mo So I think we should leave it lowercase. Thanks for the review, wish you a happy new year! |