Bug 2209067
| Summary: | Review Request: perl-File-Inplace - Perl module for in-place editing of files | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Michal Josef Spacek <mspacek> |
| Component: | Package Review | Assignee: | Jitka Plesnikova <jplesnik> |
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | jplesnik, package-review |
| Target Milestone: | --- | Flags: | jplesnik:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | perl-File-Inplace-0.20-32.fc39 | Doc Type: | If docs needed, set a value |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2023-06-20 12:40:38 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Michal Josef Spacek
2023-05-22 13:29:12 UTC
Perl module was orphaned (https://src.fedoraproject.org/rpms/perl-File-Inplace) Spec file does not exist. Source package does not exists Source file is ok
Summary is ok
License is ok
Description is ok
URL and Source0 are ok
All tests passed
BuildRequires are ok
FIX: Add build-require
- coreutils - it is needed for %{_fixperms}
- perl(strict) - File-Inplace-0.20/lib/File/Inplace.pm:2
FIX: Remove duplicate dependency 'perl(File::Copy)'
TODO: Please add version restriction for perl(ExtUtils::MakeMaker) >= 6.76
NO_PACKLIST is provided since this version.
$ rpm -qp --requires perl-File-Inplace-0.20-32.fc39.noarch.rpm | sort | uniq -c | grep -v rpmlib
1 perl(Carp)
1 perl(File::Basename)
1 perl(File::Copy)
1 perl(File::Temp)
1 perl(IO::File)
1 perl(IO::Handle)
1 perl-libs
1 perl(strict)
Binary requires are Ok.
$ rpm -qp --provides perl-File-Inplace-0.20-32.fc39.noarch.rpm | sort | uniq -c
1 perl(File::Inplace) = 0.20
1 perl-File-Inplace = 0.20-32.fc39
Binary provides are Ok.
$ rpmlint ./perl-File-Inplace*
================================== rpmlint session starts ==================================
rpmlint: 2.4.0
configuration:
/usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml
/etc/xdg/rpmlint/fedora-legacy-licenses.toml
/etc/xdg/rpmlint/fedora-spdx-licenses.toml
/etc/xdg/rpmlint/fedora.toml
/etc/xdg/rpmlint/scoring.toml
/etc/xdg/rpmlint/users-groups.toml
/etc/xdg/rpmlint/warn-on-functions.toml
checks: 31, packages: 3
=== 2 packages and 1 specfiles checked; 0 errors, 0 warnings, 0 badness; has taken 0.7 s ===
Rpmlint is ok
FIX: Explicitly name packaged files in %{_mandir}/man* and %{perl_vendorlib} directories
https://docs.fedoraproject.org/en-US/packaging-guidelines/#_explicit_lists
Otherwise the package is in line with Fedora and Perl packaging guide lines.
Please correct all 'FIX' items, consider fixing 'TODO' items and provide a new spec file.
Resolution:
Not Approved
@jplesnik Thank you for the review. Updated spec and src files: Spec URL: https://skim.cz/tmp/perl-File-Inplace-2/perl-File-Inplace.spec SRPM URL: https://skim.cz/tmp/perl-File-Inplace-2/perl-File-Inplace-0.20-32.fc39.src.rpm > BuildRequires are ok > FIX: Add build-require > - coreutils - it is needed for %{_fixperms} > - perl(strict) - File-Inplace-0.20/lib/File/Inplace.pm:2 Ok. > FIX: Remove duplicate dependency 'perl(File::Copy)' Ok. > TODO: Please add version restriction for perl(ExtUtils::MakeMaker) >= 6.76 > NO_PACKLIST is provided since this version. Ok. > > FIX: Explicitly name packaged files in %{_mandir}/man* and %{perl_vendorlib} > directories > https://docs.fedoraproject.org/en-US/packaging-guidelines/#_explicit_lists Ok. Resolution: Approved |