Spec URL: https://skim.cz/tmp/perl-File-Inplace.spec SRPM URL: https://skim.cz/tmp/perl-File-Inplace-0.20-32.fc39.src.rpm Description: File::Inplace is a perl module intended to ease the common task of editing a file in-place. Inspired by variations of perl's -i option, this module is intended for somewhat more structured and reusable editing than command line perl typically allows. File::Inplace endeavors to guarantee file integrity; that is, either all of the changes made will be saved to the file, or none will. It also offers functionality such as backup creation, automatic field splitting per-line, automatic chomping/unchomping, and aborting edits partially through without affecting the original file. Fedora Account System Username: mspacek
Perl module was orphaned (https://src.fedoraproject.org/rpms/perl-File-Inplace)
Spec file does not exist.
Source package does not exists
Source file is ok Summary is ok License is ok Description is ok URL and Source0 are ok All tests passed BuildRequires are ok FIX: Add build-require - coreutils - it is needed for %{_fixperms} - perl(strict) - File-Inplace-0.20/lib/File/Inplace.pm:2 FIX: Remove duplicate dependency 'perl(File::Copy)' TODO: Please add version restriction for perl(ExtUtils::MakeMaker) >= 6.76 NO_PACKLIST is provided since this version. $ rpm -qp --requires perl-File-Inplace-0.20-32.fc39.noarch.rpm | sort | uniq -c | grep -v rpmlib 1 perl(Carp) 1 perl(File::Basename) 1 perl(File::Copy) 1 perl(File::Temp) 1 perl(IO::File) 1 perl(IO::Handle) 1 perl-libs 1 perl(strict) Binary requires are Ok. $ rpm -qp --provides perl-File-Inplace-0.20-32.fc39.noarch.rpm | sort | uniq -c 1 perl(File::Inplace) = 0.20 1 perl-File-Inplace = 0.20-32.fc39 Binary provides are Ok. $ rpmlint ./perl-File-Inplace* ================================== rpmlint session starts ================================== rpmlint: 2.4.0 configuration: /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 31, packages: 3 === 2 packages and 1 specfiles checked; 0 errors, 0 warnings, 0 badness; has taken 0.7 s === Rpmlint is ok FIX: Explicitly name packaged files in %{_mandir}/man* and %{perl_vendorlib} directories https://docs.fedoraproject.org/en-US/packaging-guidelines/#_explicit_lists Otherwise the package is in line with Fedora and Perl packaging guide lines. Please correct all 'FIX' items, consider fixing 'TODO' items and provide a new spec file. Resolution: Not Approved
@jplesnik Thank you for the review. Updated spec and src files: Spec URL: https://skim.cz/tmp/perl-File-Inplace-2/perl-File-Inplace.spec SRPM URL: https://skim.cz/tmp/perl-File-Inplace-2/perl-File-Inplace-0.20-32.fc39.src.rpm
> BuildRequires are ok > FIX: Add build-require > - coreutils - it is needed for %{_fixperms} > - perl(strict) - File-Inplace-0.20/lib/File/Inplace.pm:2 Ok. > FIX: Remove duplicate dependency 'perl(File::Copy)' Ok. > TODO: Please add version restriction for perl(ExtUtils::MakeMaker) >= 6.76 > NO_PACKLIST is provided since this version. Ok. > > FIX: Explicitly name packaged files in %{_mandir}/man* and %{perl_vendorlib} > directories > https://docs.fedoraproject.org/en-US/packaging-guidelines/#_explicit_lists Ok. Resolution: Approved