Bug 220968
| Summary: | Review Request: scigraphica - Scientific application for data analysis and technical graphics | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Deji Akingunola <dakingun> | ||||
| Component: | Package Review | Assignee: | Paul F. Johnson <paul> | ||||
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Package Reviews List <fedora-package-review> | ||||
| Severity: | medium | Docs Contact: | |||||
| Priority: | medium | ||||||
| Version: | rawhide | CC: | mtasaka | ||||
| Target Milestone: | --- | ||||||
| Target Release: | --- | ||||||
| Hardware: | All | ||||||
| OS: | Linux | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | Doc Type: | Bug Fix | |||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2007-02-02 16:58:46 UTC | Type: | --- | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Bug Depends On: | 220967 | ||||||
| Bug Blocks: | 163779 | ||||||
| Attachments: |
|
||||||
|
Description
Deji Akingunola
2006-12-29 18:49:14 UTC
I've got libscigraphica so I shall do this as well :-) rpmlint is giving 2 warnings for the main package - looks like you need a devel subpackage adding W: scigraphica devel-file-in-non-devel-package /usr/share/pixmaps/scigraphica/stock_pixmaps.h W: scigraphica devel-file-in-non-devel-package /usr/share/pixmaps/scigraphica/pixmaps.h Builds cleanly in mock (In reply to comment #2) > rpmlint is giving 2 warnings for the main package - looks like you need a devel > subpackage adding > > W: scigraphica devel-file-in-non-devel-package > /usr/share/pixmaps/scigraphica/stock_pixmaps.h > W: scigraphica devel-file-in-non-devel-package > /usr/share/pixmaps/scigraphica/pixmaps.h > The rpmlint warnings can be ignored as those *.h are just listings of the contained pixmaps, I don't think they are being used to build anything. I've corrected the package not to own %{_libdir}/%{name} (already owned by libscigraphical) but it sub-directory that it creates. Spec URL: ftp://czar.eas.yorku.ca/pub/scigraphica/scigraphica.spec SRPM URL: ftp://czar.eas.yorku.ca/pub/scigraphica/scigraphica-2.1.0-2.src.rpm NO. scigraphica should own the libdir and libscigraphica should add to it - NOT the other way around! Please correct libscigraphica first. Apparently --------------------------------------- BuildRequires: gtk2-devel gtk+extra-devel BuildRequires: pkgconfig --------------------------------------- This should be required by libscigraphica-devel, not by BuildRequires of this package. ---------------------------------------- %post -p /sbin/ldconfig %postun -p /sbin/ldconfig ---------------------------------------- This is not necessary because no libraries installed by this package are installed under default path on which ldconfig tries to search. (In reply to comment #5) > NO. > scigraphica should own the libdir and libscigraphica > should add to it - NOT the > other way around! See my comments on bug 220967. With fixes, Spec URL: ftp://czar.eas.yorku.ca/pub/scigraphica/scigraphica.spec SRPM URL: ftp://czar.eas.yorku.ca/pub/scigraphica/scigraphica-2.1.0-3.src.rpm I discovered building this package (as is in last spec) fails when python-numarry is installed. This is because the configure script is kinda confused by python-numarry and python-numeric both providing 'arrayobject.h'. This is resolved in this build. Spec URL: ftp://czar.eas.yorku.ca/pub/scigraphica/scigraphica.spec SRPM URL: ftp://czar.eas.yorku.ca/pub/scigraphica/scigraphica-2.1.0-4.src.rpm Seemingly okay (quickly checked), I leave this package as judgment by Paul. ONE NOTE: On current FC-devel, scigraphica (actually libscigraphica) causes segv on exit. However, I suspect that this is due to ORBit2 or gtk2 or something else (strongly suspect ORBit2). Fails to build in mock. You need to add BR gtk2-devel to the spec (In reply to comment #11) > Fails to build in mock. You need to add BR gtk2-devel to the spec Really? Rebuilding scigraphica requires libscigraphica-devel (bug 220967), libscigraphica-devel requires gtk+extras-devel, and gtk+extra-devel requires gtk2-devel... For me mockbuild succeeds (with libscigraphica(-devel) correctly installed for scigraphica mockbuild). Created attachment 146085 [details]
Mock build log of scigraphica-2.1.0-4.fc7
Mockbuild log of scigraphica-2.1.0-4 on FC7 i386
(for me).
Buildsys here was updated at 7am (GMT) today which would have sucked in any libscigraphica updates. Mock fails to build here full stop. Then, still fails on mockbuild? If so, would you attach a mockbuild log with --debug option? (In reply to comment #14) > Buildsys here was updated at 7am (GMT) today which would have sucked in any > libscigraphica updates. Mock fails to build here full stop. It seems to me (from the tone of the message) that you think libscigraphica is in Extras tree already; but the review (bug #220967) is still waiting on you. Okay, it's happy again! rpmlint is not quiet - it's complaining about the two .h files in pixmaps. I've looked at them and will allow it on this occassion. I'm not happy though. mock is happy (x86) Review Good Consistent use of macros No permission or ownership issues No static libs docs included devel not built, no pkgconfig required rpm not missing any required software actually works Includes desktop icon Unhappy but will allow .h files in non-devel package APPROVED Imported and built too. |