Bug 220968 - Review Request: scigraphica - Scientific application for data analysis and technical graphics
Review Request: scigraphica - Scientific application for data analysis and te...
Status: CLOSED NEXTRELEASE
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
rawhide
All Linux
medium Severity medium
: ---
: ---
Assigned To: Paul F. Johnson
Fedora Package Reviews List
:
Depends On: 220967
Blocks: FE-ACCEPT
  Show dependency treegraph
 
Reported: 2006-12-29 13:49 EST by Deji Akingunola
Modified: 2007-11-30 17:11 EST (History)
1 user (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2007-02-02 11:58:46 EST
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---


Attachments (Terms of Use)
Mock build log of scigraphica-2.1.0-4.fc7 (161.57 KB, text/plain)
2007-01-21 08:24 EST, Mamoru TASAKA
no flags Details

  None (edit)
Description Deji Akingunola 2006-12-29 13:49:14 EST
Spec URL: ftp://czar.eas.yorku.ca/pub/scigraphica/scigraphica.spec
SRPM URL: ftp://czar.eas.yorku.ca/pub/scigraphica/scigraphica-2.1.0-1.src.rpm
Description: SciGraphica is a free (GPL) scientific application for data analysis and
technical graphics. It pretends to be a clone of the popular commercial
(and expensive) application "Microcal Origin". It fully supplies plotting
features for 2D, 3D and polar charts.

Please note that this will not build in mock at the moment, as it depends on libscigraphica, which I've just submitted for reviews.
Comment 1 Paul F. Johnson 2006-12-29 13:52:30 EST
I've got libscigraphica so I shall do this as well :-)
Comment 2 Paul F. Johnson 2006-12-31 08:38:35 EST
rpmlint is giving 2 warnings for the main package - looks like you need a devel
subpackage adding

W: scigraphica devel-file-in-non-devel-package
/usr/share/pixmaps/scigraphica/stock_pixmaps.h
W: scigraphica devel-file-in-non-devel-package
/usr/share/pixmaps/scigraphica/pixmaps.h

Comment 3 Paul F. Johnson 2006-12-31 09:22:48 EST
Builds cleanly in mock
Comment 4 Deji Akingunola 2006-12-31 18:28:54 EST
(In reply to comment #2)
> rpmlint is giving 2 warnings for the main package - looks like you need a devel
> subpackage adding
> 
> W: scigraphica devel-file-in-non-devel-package
> /usr/share/pixmaps/scigraphica/stock_pixmaps.h
> W: scigraphica devel-file-in-non-devel-package
> /usr/share/pixmaps/scigraphica/pixmaps.h
> 
The rpmlint warnings can be ignored as those *.h are just listings of the
contained pixmaps, I don't think they are being used to build anything.
I've corrected the package not to own %{_libdir}/%{name} (already owned by
libscigraphical) but it sub-directory that it creates.

Spec URL: ftp://czar.eas.yorku.ca/pub/scigraphica/scigraphica.spec
SRPM URL: ftp://czar.eas.yorku.ca/pub/scigraphica/scigraphica-2.1.0-2.src.rpm


Comment 5 Paul F. Johnson 2007-01-01 08:17:26 EST
NO.

scigraphica should own the libdir and libscigraphica should add to it - NOT the
other way around!
Comment 6 Mamoru TASAKA 2007-01-01 10:25:01 EST
Please correct libscigraphica first.

Apparently
---------------------------------------
BuildRequires:	gtk2-devel gtk+extra-devel
BuildRequires:  pkgconfig
---------------------------------------
This should be required by libscigraphica-devel, not by
BuildRequires of this package.

----------------------------------------
%post -p /sbin/ldconfig
%postun -p /sbin/ldconfig
----------------------------------------
This is not necessary because no libraries installed
by this package are installed under default path on which
ldconfig tries to search.

(In reply to comment #5)
> NO.
> scigraphica should own the libdir and libscigraphica 
> should add to it - NOT the
> other way around!
See my comments on bug 220967.
Comment 8 Deji Akingunola 2007-01-01 21:44:25 EST
I discovered building this package (as is in last spec) fails when
python-numarry is installed. This is because the configure script is kinda
confused by python-numarry and python-numeric both providing 'arrayobject.h'.
This is resolved in this build.

Spec URL: ftp://czar.eas.yorku.ca/pub/scigraphica/scigraphica.spec
SRPM URL: ftp://czar.eas.yorku.ca/pub/scigraphica/scigraphica-2.1.0-4.src.rpm
Comment 9 Mamoru TASAKA 2007-01-03 06:31:34 EST
Seemingly okay (quickly checked), I leave this package as 
judgment by Paul.
Comment 10 Mamoru TASAKA 2007-01-03 06:40:55 EST
ONE NOTE:

On current FC-devel, scigraphica (actually libscigraphica) causes
segv on exit. However, I suspect that this is due to ORBit2 or gtk2 or
something else (strongly suspect ORBit2).
Comment 11 Paul F. Johnson 2007-01-21 05:58:35 EST
Fails to build in mock. You need to add BR gtk2-devel to the spec
Comment 12 Mamoru TASAKA 2007-01-21 08:21:43 EST
(In reply to comment #11)
> Fails to build in mock. You need to add BR gtk2-devel to the spec

Really?
Rebuilding scigraphica requires libscigraphica-devel (bug 220967),
libscigraphica-devel requires gtk+extras-devel, and
gtk+extra-devel requires gtk2-devel...

For me mockbuild succeeds (with libscigraphica(-devel) correctly
installed for scigraphica mockbuild).
Comment 13 Mamoru TASAKA 2007-01-21 08:24:43 EST
Created attachment 146085 [details]
Mock build log of scigraphica-2.1.0-4.fc7

Mockbuild log of scigraphica-2.1.0-4 on FC7 i386
(for me).
Comment 14 Paul F. Johnson 2007-01-21 08:27:21 EST
Buildsys here was updated at 7am (GMT) today which would have sucked in any
libscigraphica updates. Mock fails to build here full stop.
Comment 15 Mamoru TASAKA 2007-01-21 09:19:07 EST
Then, still fails on mockbuild? If so, would you
attach a mockbuild log with --debug option?
Comment 16 Deji Akingunola 2007-01-21 23:40:59 EST
(In reply to comment #14)
> Buildsys here was updated at 7am (GMT) today which would have sucked in any
> libscigraphica updates. Mock fails to build here full stop.
It seems to me (from the tone of the message) that you think libscigraphica is
in Extras tree already; but the review (bug #220967) is still waiting on you.
Comment 17 Paul F. Johnson 2007-01-28 08:07:21 EST
Okay, it's happy again!

rpmlint is not quiet - it's complaining about the two .h files in pixmaps. I've
looked at them and will allow it on this occassion. I'm not happy though.

mock is happy (x86)

Review

Good

Consistent use of macros
No permission or ownership issues
No static libs
docs included
devel not built, no pkgconfig required
rpm not missing any required
software actually works
Includes desktop icon

Unhappy but will allow
.h files in non-devel package

APPROVED
Comment 18 Deji Akingunola 2007-02-02 11:58:46 EST
Imported and built too.

Note You need to log in before you can comment on or make changes to this bug.