Bug 2211182 (review-rust-calamine)

Summary: Review Request: rust-calamine - Excel/OpenDocument Spreadsheets reader and deserializer in pure rust
Product: [Fedora] Fedora Reporter: Michel Lind <michel>
Component: Package ReviewAssignee: Fabio Valentini <decathorpe>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: rawhideCC: decathorpe, package-review
Target Milestone: ---Flags: decathorpe: fedora-review+
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
URL: https://crates.io/crates/calamine
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2024-01-17 21:46:57 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 2211177, 2211180    
Bug Blocks: 2211172    

Description Michel Lind 2023-05-30 16:02:05 UTC
Spec URL: https://salimma.fedorapeople.org/rust-calamine.spec
SRPM URL: https://salimma.fedorapeople.org/rust-calamine-0.20.0-1.fc39.src.rpm

Description:
An Excel/OpenDocument Spreadsheets reader and deserializer in pure rust.

Fedora Account System Username: salimma

Comment 2 Fedora Review Service 2024-01-08 04:49:54 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/6871237
(failed)

Build log:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2211182-rust-calamine/fedora-rawhide-x86_64/06871237-rust-calamine/builder-live.log.gz

Please make sure the package builds successfully at least for Fedora Rawhide.

- If the build failed for unrelated reasons (e.g. temporary network
  unavailability), please ignore it.
- If the build failed because of missing BuildRequires, please make sure they
  are listed in the "Depends On" field


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 3 Fabio Valentini 2024-01-09 21:56:29 UTC
Package was generated with rust2rpm, simplifying the review.

- package builds and installs without errors on rawhide
- test suite is run and all unit tests pass (doctests disabled with explanation)
! latest version of the crate is packaged
- license matches upstream specification (MIT) and is acceptable for Fedora
- license file is included with %license in %files
- package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks:

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version filter: alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- add @rust-sig with "commit" access as package co-maintainer
  (should happen automatically)

- set bugzilla assignee overrides to @rust-sig (optional)

- track package in koschei for all built branches
  (should happen automatically once rust-sig is co-maintainer)

===

The upstream project has released v0.23.0 and v0.23.1 in the meantime. If possible, update the package to the latest version ASAP.

Comment 4 Fedora Admin user for bugzilla script actions 2024-01-12 03:18:15 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-calamine

Comment 5 Michel Lind 2024-01-12 03:20:10 UTC
Thanks! nu-command (which is still blocked on figuring out htmlescape and some other dependencies) still requests 0.22, so I'll package this first while seeing if I can get upstream to bump their dependency

https://crates.io/crates/nu-command/0.89.0/dependencies

Comment 6 Fabio Valentini 2024-01-12 16:17:55 UTC
Ok, if nu-command still requires this version, then it's fine :)

Comment 7 Fedora Update System 2024-01-17 03:53:07 UTC
FEDORA-2024-f69f145e30 has been submitted as an update to Fedora 38. https://bodhi.fedoraproject.org/updates/FEDORA-2024-f69f145e30

Comment 8 Fedora Update System 2024-01-17 03:53:08 UTC
FEDORA-2024-df9576ae81 has been submitted as an update to Fedora 39. https://bodhi.fedoraproject.org/updates/FEDORA-2024-df9576ae81

Comment 9 Fabio Valentini 2024-01-17 21:46:57 UTC
Package is available in rawhide.

Comment 10 Fedora Update System 2024-01-18 02:11:17 UTC
FEDORA-2024-f69f145e30 has been pushed to the Fedora 38 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-f69f145e30 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-f69f145e30

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 11 Fedora Update System 2024-01-19 01:39:44 UTC
FEDORA-2024-df9576ae81 has been pushed to the Fedora 39 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-df9576ae81 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-df9576ae81

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 12 Fedora Update System 2024-01-26 00:42:29 UTC
FEDORA-2024-f69f145e30 has been pushed to the Fedora 38 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 13 Fedora Update System 2024-01-27 01:28:00 UTC
FEDORA-2024-df9576ae81 has been pushed to the Fedora 39 stable repository.
If problem still persists, please make note of it in this bug report.