Bug 2211177 (review-rust-codepage) - Review Request: rust-codepage - Mapping between Windows code page numbers and encoding_rs character encodings
Summary: Review Request: rust-codepage - Mapping between Windows code page numbers and...
Keywords:
Status: CLOSED ERRATA
Alias: review-rust-codepage
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Fabio Valentini
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: review-rust-calamine
TreeView+ depends on / blocked
 
Reported: 2023-05-30 15:52 UTC by Michel Lind
Modified: 2023-06-22 02:42 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2023-06-22 02:26:59 UTC
Type: ---
Embargoed:
decathorpe: fedora-review+


Attachments (Terms of Use)

Description Michel Lind 2023-05-30 15:52:05 UTC
Spec URL: https://salimma.fedorapeople.org/rust-codepage.spec
SRPM URL: https://salimma.fedorapeople.org/rust-codepage-0.1.1-1.fc39.src.rpm

Description:
Mapping between Windows code page numbers and encoding_rs character
encodings.

Fedora Account System Username: salimma

Comment 1 Fabio Valentini 2023-06-06 19:23:37 UTC
Reading the crate description ... are you sure we actually need this crate on non-Windows?

Comment 2 Michel Lind 2023-06-09 18:55:39 UTC
(In reply to Fabio Valentini from comment #1)
> Reading the crate description ... are you sure we actually need this crate
> on non-Windows?

It's a non-optional dependency for calamine:
https://crates.io/crates/calamine/0.20.0/dependencies

Looks like you ... do need it to encode and decode Excel files. The horror!

https://github.com/search?q=repo%3Atafia%2Fcalamine%20codepage&type=code

Comment 3 Fabio Valentini 2023-06-09 19:55:06 UTC
Ugh, well that sounds "sensible" then, I guess :D

===

Package was generated with rust2rpm, simplifying the review.

- package builds and installs without errors on rawhide
- test suite is run and all unit tests pass
- latest version of the crate is packaged
- license matches upstream specification (MIT OR Apache-2.0) and is acceptable for Fedora
- license files are included with %license in %files
- package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks:

- add @rust-sig with "commit" access as package co-maintainer

- set bugzilla assignee overrides to @rust-sig (optional)

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version filter: alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- track package in koschei for all built branches

Comment 4 Fedora Admin user for bugzilla script actions 2023-06-13 17:29:17 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-codepage

Comment 5 Fedora Update System 2023-06-13 18:26:00 UTC
FEDORA-EPEL-2023-9d87d6800a has been submitted as an update to Fedora EPEL 9. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2023-9d87d6800a

Comment 6 Fedora Update System 2023-06-13 18:26:00 UTC
FEDORA-2023-221533f0a3 has been submitted as an update to Fedora 37. https://bodhi.fedoraproject.org/updates/FEDORA-2023-221533f0a3

Comment 7 Fedora Update System 2023-06-13 18:26:01 UTC
FEDORA-2023-cff5421604 has been submitted as an update to Fedora 38. https://bodhi.fedoraproject.org/updates/FEDORA-2023-cff5421604

Comment 8 Fedora Update System 2023-06-14 00:59:43 UTC
FEDORA-EPEL-2023-9d87d6800a has been pushed to the Fedora EPEL 9 testing repository.

You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2023-9d87d6800a

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 9 Fedora Update System 2023-06-14 02:32:27 UTC
FEDORA-2023-cff5421604 has been pushed to the Fedora 38 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2023-cff5421604 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-cff5421604

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 10 Fedora Update System 2023-06-14 03:00:42 UTC
FEDORA-2023-221533f0a3 has been pushed to the Fedora 37 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2023-221533f0a3 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-221533f0a3

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 11 Fedora Update System 2023-06-22 02:26:59 UTC
FEDORA-2023-cff5421604 has been pushed to the Fedora 38 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 12 Fedora Update System 2023-06-22 02:37:58 UTC
FEDORA-2023-221533f0a3 has been pushed to the Fedora 37 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 13 Fedora Update System 2023-06-22 02:42:33 UTC
FEDORA-EPEL-2023-9d87d6800a has been pushed to the Fedora EPEL 9 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.