Bug 2211190 (review-rust-dtparse)

Summary:	Review Request: rust-dtparse - Dateutil-compatible timestamp parser for Rust
Product:	[Fedora] Fedora	Reporter:	Michel Alexandre Salim <michel>
Component:	Package Review	Assignee:	Fabio Valentini <decathorpe>
Status:	POST ---	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	rawhide	CC:	decathorpe, package-review
Target Milestone:	---	Flags:	decathorpe: fedora-review+
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:		Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	2211172

Description Michel Alexandre Salim 2023-05-30 16:26:19 UTC

Spec URL: https://salimma.fedorapeople.org/rust-dtparse.spec
SRPM URL: https://salimma.fedorapeople.org/rust-dtparse-1.4.0-1.fc39.src.rpm

Description:
A dateutil-compatible timestamp parser for Rust.

Fedora Account System Username: salimma

Comment 1 Fabio Valentini 2023-06-06 19:36:36 UTC

1. There's a bunch of files in this crate that we don't need ... or want, for that matter, because they introduce a dependency on /usr/bin/python3 due to their shebangs. Adding something like this to the [package] table in Cargo.toml would be great (can be upstreamed):

exclude = ["/*.py"]

2. There's no actual license text included.
The LICENSE file contains only a header, but not the actual Apache-2.0 license text.
Please report upstream ...

Comment 2 Michel Alexandre Salim 2023-06-09 19:33:44 UTC

https://github.com/bspeice/dtparse/pull/42 for excluding Python files. Working on the license next

Comment 3 Michel Alexandre Salim 2023-06-09 21:08:51 UTC

https://github.com/bspeice/dtparse/pull/43 for adding license text

Spec URL: https://salimma.fedorapeople.org/rust-dtparse.spec
SRPM URL: https://salimma.fedorapeople.org/rust-dtparse-1.4.0-1.fc39.src.rpm

Comment 4 Fabio Valentini 2023-06-12 13:21:59 UTC

Thanks! Upstream released a new version that contains both your PRs, can you update this package to v1.5.0?

Comment 5 Michel Alexandre Salim 2023-06-20 20:38:44 UTC

Certainly, thanks!

Spec URL: https://salimma.fedorapeople.org/rust-dtparse.spec
SRPM URL: https://salimma.fedorapeople.org/rust-dtparse-1.5.0-1.fc39.src.rpm

Comment 6 Fabio Valentini 2023-06-24 15:43:26 UTC

Thanks for the update!

===

Package was generated with rust2rpm, simplifying the review.

- package builds and installs without errors on rawhide
- test suite is run and all unit tests pass
- latest version of the crate is packaged
- license matches upstream specification (Apache-2.0) and is acceptable for Fedora
- license file is included with %license in %files
- package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks:

- add @rust-sig with "commit" access as package co-maintainer

- set bugzilla assignee overrides to @rust-sig (optional)

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version filter: alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- track package in koschei for all built branches