Bug 2211190 (review-rust-dtparse)
| Summary: | Review Request: rust-dtparse - Dateutil-compatible timestamp parser for Rust | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Michel Lind <michel> |
| Component: | Package Review | Assignee: | Fabio Valentini <decathorpe> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | rawhide | CC: | decathorpe, package-review |
| Target Milestone: | --- | Flags: | decathorpe:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2024-01-09 01:46:01 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 2211172 | ||
|
Description
Michel Lind
2023-05-30 16:26:19 UTC
1. There's a bunch of files in this crate that we don't need ... or want, for that matter, because they introduce a dependency on /usr/bin/python3 due to their shebangs. Adding something like this to the [package] table in Cargo.toml would be great (can be upstreamed): exclude = ["/*.py"] 2. There's no actual license text included. The LICENSE file contains only a header, but not the actual Apache-2.0 license text. Please report upstream ... https://github.com/bspeice/dtparse/pull/42 for excluding Python files. Working on the license next https://github.com/bspeice/dtparse/pull/43 for adding license text Spec URL: https://salimma.fedorapeople.org/rust-dtparse.spec SRPM URL: https://salimma.fedorapeople.org/rust-dtparse-1.4.0-1.fc39.src.rpm Thanks! Upstream released a new version that contains both your PRs, can you update this package to v1.5.0? Certainly, thanks! Spec URL: https://salimma.fedorapeople.org/rust-dtparse.spec SRPM URL: https://salimma.fedorapeople.org/rust-dtparse-1.5.0-1.fc39.src.rpm Thanks for the update! === Package was generated with rust2rpm, simplifying the review. - package builds and installs without errors on rawhide - test suite is run and all unit tests pass - latest version of the crate is packaged - license matches upstream specification (Apache-2.0) and is acceptable for Fedora - license file is included with %license in %files - package complies with Rust Packaging Guidelines Package APPROVED. === Recommended post-import rust-sig tasks: - add @rust-sig with "commit" access as package co-maintainer - set bugzilla assignee overrides to @rust-sig (optional) - set up package on release-monitoring.org: project: $crate homepage: https://crates.io/crates/$crate backend: crates.io version scheme: semantic version filter: alpha;beta;rc;pre distro: Fedora Package: rust-$crate - track package in koschei for all built branches ah, forgot to import The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-dtparse FEDORA-2024-840cf08157 has been submitted as an update to Fedora 38. https://bodhi.fedoraproject.org/updates/FEDORA-2024-840cf08157 FEDORA-2024-f06b105d34 has been pushed to the Fedora 39 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-f06b105d34 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-f06b105d34 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2024-840cf08157 has been pushed to the Fedora 38 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-840cf08157 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-840cf08157 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2024-f06b105d34 has been pushed to the Fedora 39 stable repository. If problem still persists, please make note of it in this bug report. FEDORA-2024-840cf08157 has been pushed to the Fedora 38 stable repository. If problem still persists, please make note of it in this bug report. |