Bug 2211190 (review-rust-dtparse) - Review Request: rust-dtparse - Dateutil-compatible timestamp parser for Rust
Summary: Review Request: rust-dtparse - Dateutil-compatible timestamp parser for Rust
Keywords:
Status: CLOSED ERRATA
Alias: review-rust-dtparse
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Fabio Valentini
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: itp-rust-nu-command
TreeView+ depends on / blocked
 
Reported: 2023-05-30 16:26 UTC by Michel Lind
Modified: 2024-01-09 02:51 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2024-01-09 01:46:01 UTC
Type: ---
Embargoed:
decathorpe: fedora-review+


Attachments (Terms of Use)

Description Michel Lind 2023-05-30 16:26:19 UTC
Spec URL: https://salimma.fedorapeople.org/rust-dtparse.spec
SRPM URL: https://salimma.fedorapeople.org/rust-dtparse-1.4.0-1.fc39.src.rpm

Description:
A dateutil-compatible timestamp parser for Rust.

Fedora Account System Username: salimma

Comment 1 Fabio Valentini 2023-06-06 19:36:36 UTC
1. There's a bunch of files in this crate that we don't need ... or want, for that matter, because they introduce a dependency on /usr/bin/python3 due to their shebangs. Adding something like this to the [package] table in Cargo.toml would be great (can be upstreamed):

exclude = ["/*.py"]

2. There's no actual license text included.
The LICENSE file contains only a header, but not the actual Apache-2.0 license text.
Please report upstream ...

Comment 2 Michel Lind 2023-06-09 19:33:44 UTC
https://github.com/bspeice/dtparse/pull/42 for excluding Python files. Working on the license next

Comment 4 Fabio Valentini 2023-06-12 13:21:59 UTC
Thanks! Upstream released a new version that contains both your PRs, can you update this package to v1.5.0?

Comment 6 Fabio Valentini 2023-06-24 15:43:26 UTC
Thanks for the update!

===

Package was generated with rust2rpm, simplifying the review.

- package builds and installs without errors on rawhide
- test suite is run and all unit tests pass
- latest version of the crate is packaged
- license matches upstream specification (Apache-2.0) and is acceptable for Fedora
- license file is included with %license in %files
- package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks:

- add @rust-sig with "commit" access as package co-maintainer

- set bugzilla assignee overrides to @rust-sig (optional)

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version filter: alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- track package in koschei for all built branches

Comment 7 Michel Lind 2024-01-07 22:49:15 UTC
ah, forgot to import

Comment 8 Fedora Admin user for bugzilla script actions 2024-01-07 22:54:29 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-dtparse

Comment 9 Fedora Update System 2024-01-07 23:31:42 UTC
FEDORA-2024-840cf08157 has been submitted as an update to Fedora 38. https://bodhi.fedoraproject.org/updates/FEDORA-2024-840cf08157

Comment 10 Fedora Update System 2024-01-08 01:36:23 UTC
FEDORA-2024-f06b105d34 has been pushed to the Fedora 39 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-f06b105d34 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-f06b105d34

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 11 Fedora Update System 2024-01-08 02:24:23 UTC
FEDORA-2024-840cf08157 has been pushed to the Fedora 38 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-840cf08157 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-840cf08157

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 12 Fedora Update System 2024-01-09 01:46:01 UTC
FEDORA-2024-f06b105d34 has been pushed to the Fedora 39 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 13 Fedora Update System 2024-01-09 02:51:24 UTC
FEDORA-2024-840cf08157 has been pushed to the Fedora 38 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.