1. There's a bunch of files in this crate that we don't need ... or want, for that matter, because they introduce a dependency on /usr/bin/python3 due to their shebangs. Adding something like this to the [package] table in Cargo.toml would be great (can be upstreamed):

exclude = ["/*.py"]

2. There's no actual license text included.
The LICENSE file contains only a header, but not the actual Apache-2.0 license text.
Please report upstream ...

https://github.com/bspeice/dtparse/pull/42 for excluding Python files. Working on the license next

https://github.com/bspeice/dtparse/pull/43 for adding license text

Spec URL: https://salimma.fedorapeople.org/rust-dtparse.spec
SRPM URL: https://salimma.fedorapeople.org/rust-dtparse-1.4.0-1.fc39.src.rpm

Thanks! Upstream released a new version that contains both your PRs, can you update this package to v1.5.0?

Certainly, thanks!

Spec URL: https://salimma.fedorapeople.org/rust-dtparse.spec
SRPM URL: https://salimma.fedorapeople.org/rust-dtparse-1.5.0-1.fc39.src.rpm

Thanks for the update!

===

Package was generated with rust2rpm, simplifying the review.

- package builds and installs without errors on rawhide
- test suite is run and all unit tests pass
- latest version of the crate is packaged
- license matches upstream specification (Apache-2.0) and is acceptable for Fedora
- license file is included with %license in %files
- package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks:

- add @rust-sig with "commit" access as package co-maintainer

- set bugzilla assignee overrides to @rust-sig (optional)

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version filter: alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- track package in koschei for all built branches