Bug 2212496

Summary: For prometheus-rules-cluster-network-addons-operator prometheusrule, runbook url for some of the networking alerts are pointing to upstream links
Product: Container Native Virtualization (CNV) Reporter: Debarati Basu-Nag <dbasunag>
Component: MetricsAssignee: Assaf Admi <aadmi>
Status: VERIFIED --- QA Contact: Debarati Basu-Nag <dbasunag>
Severity: high Docs Contact:
Priority: unspecified    
Version: 4.14.0CC: aadmi, ellorent, kmajcher, oshoval, stirabos
Target Milestone: ---   
Target Release: 4.14.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: v4.14.0.rhel9-1345 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Comment 2 Assaf Admi 2023-06-20 11:00:09 UTC
The PR in which this functionality was added should be now available in M/S, according to http://cnv-version-explorer.apps.cnv2.engineering.redhat.com/?cPRs=1547, so I expect the issue to be resolved.

Comment 3 Krzysztof Majcher 2023-06-20 12:56:43 UTC
Please add PR link to the bug.

Comment 4 Assaf Admi 2023-06-20 14:27:10 UTC
U/S PR for populating runbook URLs based on the installation - https://github.com/kubevirt/cluster-network-addons-operator/pull/1547

Comment 5 Assaf Admi 2023-06-28 10:16:49 UTC
Fixed in version - v4.14.0.rhel9-895

Comment 6 Debarati Basu-Nag 2023-07-08 13:13:00 UTC
Verified against CNV-v4.14.0.rhel9-1154

I see wrong url link for one alert:
{'KubemacpoolDown': {'alert': 'KubemacpoolDown',
 'annotations': {'runbook_url': 'https://docs.openshift.com/container-platform/4.14/virt/support/virt-runbooks.html#virt-runbook-KubeMacPoolDown',
 'summary': 'KubeMacpool is deployed by CNAO CR but KubeMacpool pod is down.'},
 'expr': 'kubevirt_cnao_cr_kubemacpool_deployed_total == 1 and '
         'kubevirt_cnao_kubemacpool_manager_num_up_pods_total == 0',
 'for': '5m',
 'labels': {'kubernetes_operator_component': 'cluster-network-addons-operator',
 'kubernetes_operator_part_of': 'kubevirt',
 'operator_health_impact': 'critical',
 'severity': 'critical'}}}

==============
Expected: https://docs.openshift.com/container-platform/4.14/virt/support/virt-runbooks.html#virt-runbook-KubemacpoolDown
Actual: https://docs.openshift.com/container-platform/4.14/virt/support/virt-runbooks.html#virt-runbook-KubeMacPoolDown

See virt-runbook-KubemacpoolDown vs virt-runbook-KubeMacPoolDown

Comment 8 Debarati Basu-Nag 2023-07-18 21:38:13 UTC
I still don't see it fixed in CNV-v4.14.0.rhel9-1278:

{'KubemacpoolDown': {'alert': 'KubemacpoolDown',
 'annotations': {'runbook_url': 'https://docs.openshift.com/container-platform/4.14/virt/support/virt-runbooks.html#virt-runbook-KubeMacPoolDown',
 'summary': 'KubeMacpool is deployed by CNAO CR but KubeMacpool pod is down.'},
 'expr': 'kubevirt_cnao_cr_kubemacpool_deployed_total == 1 and '
         'kubevirt_cnao_kubemacpool_manager_num_up_pods_total == 0',
 'for': '5m',
 'labels': {'kubernetes_operator_component': 'cluster-network-addons-operator',
 'kubernetes_operator_part_of': 'kubevirt',
 'operator_health_impact': 'critical',
 'severity': 'critical'}}}

Expected runbook_url would be https://docs.openshift.com/container-platform/4.14/virt/support/virt-runbooks.html#virt-runbook-KubemacpoolDown

Comment 9 Debarati Basu-Nag 2023-07-31 12:42:19 UTC
Verified against CNV-v4.14.0.rhel9-1404