Bug 2212496 - For prometheus-rules-cluster-network-addons-operator prometheusrule, runbook url for some of the networking alerts are pointing to upstream links
Summary: For prometheus-rules-cluster-network-addons-operator prometheusrule, runbook ...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Container Native Virtualization (CNV)
Classification: Red Hat
Component: Metrics
Version: 4.14.0
Hardware: Unspecified
OS: Unspecified
unspecified
high
Target Milestone: ---
: 4.14.0
Assignee: Assaf Admi
QA Contact: Debarati Basu-Nag
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2023-06-05 17:28 UTC by Debarati Basu-Nag
Modified: 2023-11-08 14:06 UTC (History)
5 users (show)

Fixed In Version: v4.14.0.rhel9-1345
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2023-11-08 14:05:49 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Github kubevirt cluster-network-addons-operator pull 1547 0 None Merged Use env RUNBOOK_URL_TEMPLATE for the runbooks URL template 2023-06-27 12:56:45 UTC
Github kubevirt cluster-network-addons-operator pull 1582 0 None Merged fix KubemacpoolDown runbook 2023-07-11 12:44:00 UTC
Github openshift runbooks pull 128 0 None Merged Fix KubemacpoolDown runbook 2023-07-11 12:44:00 UTC
Red Hat Issue Tracker CNV-29443 0 None None None 2023-06-06 12:54:17 UTC
Red Hat Product Errata RHSA-2023:6817 0 None None None 2023-11-08 14:06:05 UTC

Comment 2 Assaf Admi 2023-06-20 11:00:09 UTC
The PR in which this functionality was added should be now available in M/S, according to http://cnv-version-explorer.apps.cnv2.engineering.redhat.com/?cPRs=1547, so I expect the issue to be resolved.

Comment 3 Krzysztof Majcher 2023-06-20 12:56:43 UTC
Please add PR link to the bug.

Comment 4 Assaf Admi 2023-06-20 14:27:10 UTC
U/S PR for populating runbook URLs based on the installation - https://github.com/kubevirt/cluster-network-addons-operator/pull/1547

Comment 5 Assaf Admi 2023-06-28 10:16:49 UTC
Fixed in version - v4.14.0.rhel9-895

Comment 6 Debarati Basu-Nag 2023-07-08 13:13:00 UTC
Verified against CNV-v4.14.0.rhel9-1154

I see wrong url link for one alert:
{'KubemacpoolDown': {'alert': 'KubemacpoolDown',
 'annotations': {'runbook_url': 'https://docs.openshift.com/container-platform/4.14/virt/support/virt-runbooks.html#virt-runbook-KubeMacPoolDown',
 'summary': 'KubeMacpool is deployed by CNAO CR but KubeMacpool pod is down.'},
 'expr': 'kubevirt_cnao_cr_kubemacpool_deployed_total == 1 and '
         'kubevirt_cnao_kubemacpool_manager_num_up_pods_total == 0',
 'for': '5m',
 'labels': {'kubernetes_operator_component': 'cluster-network-addons-operator',
 'kubernetes_operator_part_of': 'kubevirt',
 'operator_health_impact': 'critical',
 'severity': 'critical'}}}

==============
Expected: https://docs.openshift.com/container-platform/4.14/virt/support/virt-runbooks.html#virt-runbook-KubemacpoolDown
Actual: https://docs.openshift.com/container-platform/4.14/virt/support/virt-runbooks.html#virt-runbook-KubeMacPoolDown

See virt-runbook-KubemacpoolDown vs virt-runbook-KubeMacPoolDown

Comment 8 Debarati Basu-Nag 2023-07-18 21:38:13 UTC
I still don't see it fixed in CNV-v4.14.0.rhel9-1278:

{'KubemacpoolDown': {'alert': 'KubemacpoolDown',
 'annotations': {'runbook_url': 'https://docs.openshift.com/container-platform/4.14/virt/support/virt-runbooks.html#virt-runbook-KubeMacPoolDown',
 'summary': 'KubeMacpool is deployed by CNAO CR but KubeMacpool pod is down.'},
 'expr': 'kubevirt_cnao_cr_kubemacpool_deployed_total == 1 and '
         'kubevirt_cnao_kubemacpool_manager_num_up_pods_total == 0',
 'for': '5m',
 'labels': {'kubernetes_operator_component': 'cluster-network-addons-operator',
 'kubernetes_operator_part_of': 'kubevirt',
 'operator_health_impact': 'critical',
 'severity': 'critical'}}}

Expected runbook_url would be https://docs.openshift.com/container-platform/4.14/virt/support/virt-runbooks.html#virt-runbook-KubemacpoolDown

Comment 9 Debarati Basu-Nag 2023-07-31 12:42:19 UTC
Verified against CNV-v4.14.0.rhel9-1404

Comment 11 errata-xmlrpc 2023-11-08 14:05:49 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Important: OpenShift Virtualization 4.14.0 Images security and bug fix update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2023:6817


Note You need to log in before you can comment on or make changes to this bug.