Bug 2213209

Summary:	Review Request: rust-serdect - Constant-time serializer/deserializer helpers for serde
Product:	[Fedora] Fedora	Reporter:	Fabio Valentini <decathorpe>
Component:	Package Review	Assignee:	Michel Lind <michel>
Status:	CLOSED RAWHIDE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	rawhide	CC:	michel, package-review
Target Milestone:	---	Flags:	michel: fedora-review+
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2023-06-08 10:44:20 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	2082961, 2213263, 2213264, 2213265, 2213266, 2213268

Description Fabio Valentini 2023-06-07 13:15:27 UTC

Spec URL: https://decathorpe.fedorapeople.org/rust-serdect.spec
SRPM URL: https://decathorpe.fedorapeople.org/rust-serdect-0.2.0-1.fc38.src.rpm

Description:
Constant-time serde serializer/deserializer helpers for data that
potentially contains secrets (e.g. cryptographic keys).

Fedora Account System Username: decathorpe

Comment 1 Fabio Valentini 2023-06-07 13:15:30 UTC

This package built on koji:  https://koji.fedoraproject.org/koji/taskinfo?taskID=101904463

Comment 2 Michel Lind 2023-06-08 02:06:31 UTC

Package was generated with rust2rpm, simplifying the review.

One nit: rpmlint throws an error that the summary is too long, can you reword it when importing?

maybe "Constant-time serde serializer/deserializer helpers for potentially secret data"

- package builds and installs without errors on rawhide
- test suite is run and all unit tests pass
- latest version of the crate is packaged
- license matches upstream specification (Apache-2.0 OR MIT) and is acceptable for Fedora
- license file is included with %license in %files
- package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks:

- add @rust-sig with "commit" access as package co-maintainer

- set bugzilla assignee overrides to @rust-sig (optional)

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version filter: alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- track package in koschei for all built branches

Comment 3 Fedora Admin user for bugzilla script actions 2023-06-08 09:19:45 UTC

The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-serdect

Comment 4 Fabio Valentini 2023-06-08 09:20:02 UTC

Thanks for the review! I'll trim the summary before import.

Comment 5 Fabio Valentini 2023-06-08 10:44:20 UTC

Imported and built:
https://koji.fedoraproject.org/koji/buildinfo?buildID=2210786