Bug 2213268 - Review Request: rust-p384 - Pure Rust implementation of the NIST P-384
Summary: Review Request: rust-p384 - Pure Rust implementation of the NIST P-384
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Aleksei Bavshin
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: 2213209 2213264 2213265 2213266
Blocks: 2213269
TreeView+ depends on / blocked
 
Reported: 2023-06-07 16:57 UTC by Fabio Valentini
Modified: 2023-06-13 10:26 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2023-06-13 10:26:54 UTC
Type: ---
Embargoed:
alebastr89: fedora-review+


Attachments (Terms of Use)

Description Fabio Valentini 2023-06-07 16:57:31 UTC
Spec URL: https://decathorpe.fedorapeople.org/rust-p384.spec
SRPM URL: https://decathorpe.fedorapeople.org/rust-p384-0.13.0-1.fc38.src.rpm

Description:
Pure Rust implementation of the NIST P-384 (a.k.a. secp384r1) elliptic
curve as defined in SP 800-186 with support for ECDH, ECDSA
signing/verification, and general purpose curve arithmetic support.

Fedora Account System Username: decathorpe

Comment 1 Aleksei Bavshin 2023-06-13 05:44:59 UTC
The package was generated with rust2rpm, simplifying the review. No issues with license or dependencies. secp384r1 is in a "good" list of ECC curves.

Approved.
---
Small nit: summary could be extended to 'Pure Rust implementation of the NIST P-384 elliptic curve' to make it more obvious for those who don't remember all the scary abbreviations.

Comment 2 Fabio Valentini 2023-06-13 10:00:40 UTC
Thanks for the review! I'll take a look at improving the Summary, it looks truncated badly anyway.

Comment 3 Fedora Admin user for bugzilla script actions 2023-06-13 10:01:01 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-p384

Comment 4 Fabio Valentini 2023-06-13 10:26:54 UTC
Imported and built (with improved summary):
https://bodhi.fedoraproject.org/updates/FEDORA-2023-b62f327d6a


Note You need to log in before you can comment on or make changes to this bug.