Bug 2213264

Summary:	Review Request: rust-elliptic-curve - General purpose Elliptic Curve Cryptography
Product:	[Fedora] Fedora	Reporter:	Fabio Valentini <decathorpe>
Component:	Package Review	Assignee:	Michel Lind <michel>
Status:	CLOSED RAWHIDE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	rawhide	CC:	michel, package-review
Target Milestone:	---	Flags:	michel: fedora-review+
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	rust-elliptic-curve-0.13.5-1.fc39	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2023-06-08 19:34:45 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	2082961, 2211921, 2213209, 2213263
Bug Blocks:	2213265, 2213266, 2213268

Description Fabio Valentini 2023-06-07 16:54:59 UTC

Spec URL: https://decathorpe.fedorapeople.org/rust-elliptic-curve.spec
SRPM URL: https://decathorpe.fedorapeople.org/rust-elliptic-curve-0.13.5-1.fc38.src.rpm

Description:
General purpose Elliptic Curve Cryptography (ECC) support, including
types and traits for representing various elliptic curve forms, scalars,
points, and public/secret keys composed thereof.

Fedora Account System Username: decathorpe

Comment 1 Michel Lind 2023-06-08 18:23:08 UTC

Package was generated with rust2rpm, simplifying the review.

- package builds and installs without errors on rawhide
- test suite is run and all unit tests pass
- latest version of the crate is packaged
- license matches upstream specification (Apache-2.0 OR MIT) and is acceptable for Fedora
- license file is included with %license in %files
- package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks:

- add @rust-sig with "commit" access as package co-maintainer

- set bugzilla assignee overrides to @rust-sig (optional)

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version filter: alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- track package in koschei for all built branches

Comment 2 Fabio Valentini 2023-06-08 19:16:05 UTC

Thanks for the review!

Comment 3 Fedora Admin user for bugzilla script actions 2023-06-08 19:16:36 UTC

The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-elliptic-curve

Comment 4 Fabio Valentini 2023-06-08 19:34:45 UTC

Imported and built:
https://bodhi.fedoraproject.org/updates/FEDORA-2023-0145b110dd