Bug 2213268

Summary: Review Request: rust-p384 - Pure Rust implementation of the NIST P-384
Product: [Fedora] Fedora Reporter: Fabio Valentini <decathorpe>
Component: Package ReviewAssignee: Aleksei Bavshin <alebastr89>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: rawhideCC: alebastr89, package-review
Target Milestone: ---Flags: alebastr89: fedora-review+
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2023-06-13 10:26:54 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 2213209, 2213264, 2213265, 2213266    
Bug Blocks: 2213269    

Description Fabio Valentini 2023-06-07 16:57:31 UTC 
Spec URL: https://decathorpe.fedorapeople.org/rust-p384.spec
SRPM URL: https://decathorpe.fedorapeople.org/rust-p384-0.13.0-1.fc38.src.rpm

Description:
Pure Rust implementation of the NIST P-384 (a.k.a. secp384r1) elliptic
curve as defined in SP 800-186 with support for ECDH, ECDSA
signing/verification, and general purpose curve arithmetic support.

Fedora Account System Username: decathorpe
Comment 1 Aleksei Bavshin 2023-06-13 05:44:59 UTC 
The package was generated with rust2rpm, simplifying the review. No issues with license or dependencies. secp384r1 is in a "good" list of ECC curves.

Approved.
---
Small nit: summary could be extended to 'Pure Rust implementation of the NIST P-384 elliptic curve' to make it more obvious for those who don't remember all the scary abbreviations.
Comment 2 Fabio Valentini 2023-06-13 10:00:40 UTC 
Thanks for the review! I'll take a look at improving the Summary, it looks truncated badly anyway.
Comment 3 Fedora Admin user for bugzilla script actions 2023-06-13 10:01:01 UTC 
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-p384
Comment 4 Fabio Valentini 2023-06-13 10:26:54 UTC 
Imported and built (with improved summary):
https://bodhi.fedoraproject.org/updates/FEDORA-2023-b62f327d6a