Bug 221349
| Summary: | Review Request: doodle - tool to quickly search the documents on a computer | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Karol Trzcionka <karlikt> | ||||
| Component: | Package Review | Assignee: | Mamoru TASAKA <mtasaka> | ||||
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Package Reviews List <fedora-package-review> | ||||
| Severity: | medium | Docs Contact: | |||||
| Priority: | medium | ||||||
| Version: | rawhide | CC: | mtasaka | ||||
| Target Milestone: | --- | ||||||
| Target Release: | --- | ||||||
| Hardware: | All | ||||||
| OS: | Linux | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | Doc Type: | Bug Fix | |||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2007-01-07 13:08:27 UTC | Type: | --- | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Bug Depends On: | 214087 | ||||||
| Bug Blocks: | 163779 | ||||||
| Attachments: |
|
||||||
|
Description
Karol Trzcionka
2007-01-03 23:47:13 UTC
Well, actually I requested doodle. Then: Your package does not provide doodled (i.e. rebuilding your srpm does not create /usr/bin/doodled). The homepage (1) says that doodled requires fam, which is replaced by gamin. The spec file provided by dag.wieers.com (2) seems that doodled can be used with the help of gamin, so please modify your spec file to use gamin so that doodled can be used. Also, accroding to "Hints for system administrators" on the homepage doodled can be run as a daemon. In this case, providing initscript service scripts (usually under /etc/rc.d/init.d ) is recommended. Would you provide it? 1. http://gnunet.org/doodle/ 2. http://dag.wieers.com/packages/doodle/doodle.spec Created attachment 144826 [details]
Mock build log of doodle-0.6.6-1
Mockbuild log of doodle-0.6.6-1 on FC-devel i386.
You can see that /usr/bin/doodled is not installed.
(In reply to comment #1) > Well, actually I requested doodle. Then: > > Your package does not provide doodled (i.e. rebuilding your > srpm does not create /usr/bin/doodled). The homepage (1) says > that doodled requires fam, which is replaced by gamin. > The spec file provided by dag.wieers.com (2) seems that > doodled can be used with the help of gamin, so please > modify your spec file to use gamin so that doodled can be used. > Fixed > Also, accroding to "Hints for system administrators" on the homepage > doodled can be run as a daemon. In this case, providing > initscript service scripts (usually under /etc/rc.d/init.d ) > is recommended. Would you provide it? > > 1. http://gnunet.org/doodle/ > 2. http://dag.wieers.com/packages/doodle/doodle.spec The initscript is a problem. The doodled need argument which directory it monitors and the doodled can be run more then once in the same time. The doodled in initscript can be run with argument i.e. "/home", but the progam is limited to monitoring less than 1024 directories for changes, so the "/home" sometimes can be too big. I think it must be discussed. New files: Spec URL: http://karlik.nonlogic.org/doodle/doodle.spec SRPM URL: http://karlik.nonlogic.org/doodle/doodle-0.6.6-2.src.rpm I will review this later. Well, = now mockbuild for conditional dependency is okay = License is "actually" GPL = Other things are all okay. = Your other review requests seems good from a very quick check. ---------------------------------------------------------- This package (doodle) is APPROVED by me. ---------------------------------------------------------- Please step forward according to http://fedoraproject.org/wiki/Extras/Contributors . At a stage, I should receive a main which notices that you need a sponsor. Then I will SPONSOR YOU. Oh.. I just noticed that you already requested for sponsorship. Now I am sponsoring you and you should receive a mail. (In reply to comment #6) > Oh.. I just noticed that you already requested for > sponsorship. > > Now I am sponsoring you and you should receive a mail. Thank You for sponsorship. The package was built correctly on buildsys (all arch, devel), so I can close this request. |