Bug 2214338
| Summary: | Review Request: rust-databake - Trait that lets structs represent themselves as (const) Rust expressions | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Fabio Valentini <decathorpe> |
| Component: | Package Review | Assignee: | blinxen <h-k-81> |
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | rawhide | CC: | h-k-81, package-review |
| Target Milestone: | --- | Flags: | h-k-81:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | rust-databake-0.1.5-1.fc39 | Doc Type: | If docs needed, set a value |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2023-07-05 23:12:36 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 2214343 | ||
| Bug Blocks: | 2214339 | ||
|
Description
Fabio Valentini
2023-06-12 17:00:46 UTC
Taking this review General comments: - Package was generated with rust2rpm and the "-a" was added to all "%cargo*" commands Since this package only builds in rawhide and fedora-review is currently broken in rawhide I can't paste the review template here. But this package fulfills all fedora packaging requirements. APPROVED Thanks for the review! Yeah I added the "-a" flag because otherwise tests don't compile (they require additional features to be enabled). The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-databake Imported and built: https://bodhi.fedoraproject.org/updates/FEDORA-2023-22be7fee6a |