Bug 2214338 - Review Request: rust-databake - Trait that lets structs represent themselves as (const) Rust expressions
Summary: Review Request: rust-databake - Trait that lets structs represent themselves ...
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: blinxen
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: 2214343
Blocks: 2214339
TreeView+ depends on / blocked
 
Reported: 2023-06-12 17:00 UTC by Fabio Valentini
Modified: 2023-07-05 23:12 UTC (History)
2 users (show)

Fixed In Version: rust-databake-0.1.5-1.fc39
Clone Of:
Environment:
Last Closed: 2023-07-05 23:12:36 UTC
Type: ---
Embargoed:
h-k-81: fedora-review+

Attachments (Terms of Use)

Description Fabio Valentini 2023-06-12 17:00:46 UTC 
Spec URL: https://decathorpe.fedorapeople.org/rust-databake.spec
SRPM URL: https://decathorpe.fedorapeople.org/rust-databake-0.1.5-1.fc38.src.rpm

Description:
Trait that lets structs represent themselves as (const) Rust
expressions.

Fedora Account System Username: decathorpe
Comment 1 Fabio Valentini 2023-06-12 17:15:43 UTC 
COPR build:
https://copr.fedorainfracloud.org/coprs/decathorpe/gimoji/build/6064237/
Comment 2 blinxen 2023-07-05 22:06:40 UTC 
Taking this review

General comments:

- Package was generated with rust2rpm and the "-a" was added to all "%cargo*" commands

Since this package only builds in rawhide and fedora-review is currently broken in rawhide I can't paste the review template here. But this package fulfills all fedora packaging requirements.

APPROVED
Comment 3 Fabio Valentini 2023-07-05 22:23:48 UTC 
Thanks for the review!

Yeah I added the "-a" flag because otherwise tests don't compile (they require additional features to be enabled).
Comment 4 Fedora Admin user for bugzilla script actions 2023-07-05 22:24:23 UTC 
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-databake
Comment 5 Fabio Valentini 2023-07-05 23:12:36 UTC 
Imported and built:
https://bodhi.fedoraproject.org/updates/FEDORA-2023-22be7fee6a
Note You need to log in before you can comment on or make changes to this bug.