Bug 2215869
| Summary: | Review Request: golang-github-minio-selfupdate - Build self-updating Go programs | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Mikel Olasagasti Uranga <mikel> | ||||
| Component: | Package Review | Assignee: | Robert-André Mauchin 🐧 <zebob.m> | ||||
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||
| Severity: | medium | Docs Contact: | |||||
| Priority: | medium | ||||||
| Version: | rawhide | CC: | package-review, zebob.m | ||||
| Target Milestone: | --- | Flags: | zebob.m:
fedora-review+
|
||||
| Target Release: | --- | ||||||
| Hardware: | All | ||||||
| OS: | Linux | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2023-07-27 08:48:03 UTC | Type: | --- | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Bug Depends On: | 2215864 | ||||||
| Bug Blocks: | 2177476 | ||||||
| Attachments: |
|
||||||
|
Description
Mikel Olasagasti Uranga
2023-06-19 09:20:46 UTC
Licenses issues :
internal/binarydist/License is MIT and not specified in the License field.
Also you should add the license breakdown :
Name: %{goname}
Release: %autorelease
Summary: Build self-updating Go programs
# Main library: Apache-2.0
# internal/binarydist: MIT
# internal/osext: BSD-3-Clause
License: BSD-3-Clause AND Apache-2.0 AND MIT
URL: %{gourl}
Source: %{gosource}
- Latest version packaged
- Builds in mock
- No rpmlint errors
- Conforms to Go Packaging Guidelines
Please post aan updated SPEC with the license update and I'll approve.
(please needinfo me or ping me on Matrix, wont be available this week-end though) Spec URL: https://mikel.olasagasti.info/tmp/fedora/golang-github-minio-selfupdate.spec SRPM URL: https://mikel.olasagasti.info/tmp/fedora/golang-github-minio-selfupdate-0.6.0-1.fc38.src.rpm Please add the license breakdown in comment as mentioned above. Actually it would be nice to add the license file directly too :
# Generated by go2rpm 1.9.0
%bcond_without check
%global debug_package %{nil}
# https://github.com/minio/selfupdate
%global goipath github.com/minio/selfupdate
Version: 0.6.0
%gometa -f
%global common_description %{expand:
Build self-updating Go programs.}
%global golicenses NOTICE LICENSE.minisig LICENSE\\\
LICENSE-binarydist LICENSE-osext
%global godocs README.md
Name: %{goname}
Release: %autorelease
Summary: Build self-updating Go programs
# Main library: Apache-2.0
# internal/binarydist: MIT
# internal/osext: BSD-3-Clause
License: Apache-2.0 AND BSD-3-Clause AND MIT
URL: %{gourl}
Source: %{gosource}
BuildRequires: bsdiff
%description %{common_description}
%gopkg
%prep
%goprep
%autopatch -p1
mv internal/binarydist/License LICENSE-binarydist
mv internal/osext/LICENSE LICENSE-osext
%generate_buildrequires
%go_generate_buildrequires
%install
%gopkginstall
%if %{with check}
%check
%gocheck
%endif
%gopkgfiles
%changelog
%autochangelog
Spec URL: https://mikel.olasagasti.info/tmp/fedora/golang-github-minio-selfupdate.spec SRPM URL: https://mikel.olasagasti.info/tmp/fedora/golang-github-minio-selfupdate-0.6.0-1.fc38.src.rpm Created attachment 1980197 [details]
The .spec file difference from Copr build 6215173 to 6215203
LGTM. Approved. The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-github-minio-selfupdate FEDORA-2023-8dc8dfaffe has been submitted as an update to Fedora 39. https://bodhi.fedoraproject.org/updates/FEDORA-2023-8dc8dfaffe FEDORA-2023-8dc8dfaffe has been pushed to the Fedora 39 stable repository. If problem still persists, please make note of it in this bug report. |