Bug 2215869 - Review Request: golang-github-minio-selfupdate - Build self-updating Go programs
Summary: Review Request: golang-github-minio-selfupdate - Build self-updating Go programs
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Robert-André Mauchin 🐧
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: 2215864
Blocks: 2177476
TreeView+ depends on / blocked
 
Reported: 2023-06-19 09:20 UTC by Mikel Olasagasti Uranga
Modified: 2023-07-27 08:48 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2023-07-27 08:48:03 UTC
Type: ---
Embargoed:
zebob.m: fedora-review+


Attachments (Terms of Use)
The .spec file difference from Copr build 6215173 to 6215203 (922 bytes, patch)
2023-07-26 21:58 UTC, Fedora Review Service
no flags Details | Diff

Description Mikel Olasagasti Uranga 2023-06-19 09:20:46 UTC
Spec URL: https://mikel.olasagasti.info/tmp/fedora/golang-github-minio-selfupdate.spec
SRPM URL: https://mikel.olasagasti.info/tmp/fedora/golang-github-minio-selfupdate-0.6.0-1.fc38.src.rpm
Description: Build self-updating Go programs.
Fedora Account System Username: mikelo2

Comment 1 Robert-André Mauchin 🐧 2023-07-26 19:49:53 UTC
Licenses issues :

internal/binarydist/License is MIT and not specified in the License field.

Also you should add the license breakdown :

Name:           %{goname}
Release:        %autorelease
Summary:        Build self-updating Go programs

# Main library: Apache-2.0
# internal/binarydist: MIT
# internal/osext: BSD-3-Clause
License:        BSD-3-Clause AND Apache-2.0 AND MIT
URL:            %{gourl}
Source:         %{gosource}





 - Latest version packaged
 - Builds in mock
 - No rpmlint errors
 - Conforms to Go Packaging Guidelines


Please post aan updated SPEC with the license update and I'll approve.

Comment 2 Robert-André Mauchin 🐧 2023-07-26 19:50:52 UTC
(please needinfo me or ping me on Matrix, wont be available this week-end though)

Comment 4 Robert-André Mauchin 🐧 2023-07-26 21:36:13 UTC
Please add the license breakdown in comment as mentioned above.

Comment 5 Robert-André Mauchin 🐧 2023-07-26 21:39:56 UTC
Actually it would be nice to add the license file directly too :


# Generated by go2rpm 1.9.0
%bcond_without check
%global debug_package %{nil}

# https://github.com/minio/selfupdate
%global goipath         github.com/minio/selfupdate
Version:                0.6.0

%gometa -f


%global common_description %{expand:
Build self-updating Go programs.}

%global golicenses      NOTICE LICENSE.minisig LICENSE\\\
                        LICENSE-binarydist LICENSE-osext
%global godocs          README.md

Name:           %{goname}
Release:        %autorelease
Summary:        Build self-updating Go programs

# Main library: Apache-2.0
# internal/binarydist: MIT
# internal/osext: BSD-3-Clause
License:        Apache-2.0 AND BSD-3-Clause AND MIT
URL:            %{gourl}
Source:         %{gosource}

BuildRequires:  bsdiff

%description %{common_description}

%gopkg

%prep
%goprep
%autopatch -p1
mv internal/binarydist/License LICENSE-binarydist
mv internal/osext/LICENSE LICENSE-osext

%generate_buildrequires
%go_generate_buildrequires

%install
%gopkginstall

%if %{with check}
%check
%gocheck
%endif

%gopkgfiles

%changelog
%autochangelog

Comment 7 Fedora Review Service 2023-07-26 21:58:20 UTC
Created attachment 1980197 [details]
The .spec file difference from Copr build 6215173 to 6215203

Comment 8 Robert-André Mauchin 🐧 2023-07-26 22:58:34 UTC
LGTM.

Approved.

Comment 9 Fedora Admin user for bugzilla script actions 2023-07-27 08:31:55 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-github-minio-selfupdate

Comment 10 Fedora Update System 2023-07-27 08:45:46 UTC
FEDORA-2023-8dc8dfaffe has been submitted as an update to Fedora 39. https://bodhi.fedoraproject.org/updates/FEDORA-2023-8dc8dfaffe

Comment 11 Fedora Update System 2023-07-27 08:48:03 UTC
FEDORA-2023-8dc8dfaffe has been pushed to the Fedora 39 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.