Bug 221703
| Summary: | Ligatures displayed incorrectly in Firefox | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Nicolas Mailhot <nicolas.mailhot> | ||||
| Component: | firefox | Assignee: | Martin Stransky <stransky> | ||||
| Status: | CLOSED ERRATA | QA Contact: | |||||
| Severity: | medium | Docs Contact: | |||||
| Priority: | medium | ||||||
| Version: | rawhide | CC: | behdad, cra, gecko-bugs-nobody, nicolas.mailhot, stransky, tjanouse, wtogami, zaitcev | ||||
| Target Milestone: | --- | ||||||
| Target Release: | --- | ||||||
| Hardware: | All | ||||||
| OS: | Linux | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | 1.1.3-2.fc7 | Doc Type: | Bug Fix | ||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2007-07-30 17:06:32 UTC | Type: | --- | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Bug Depends On: | |||||||
| Bug Blocks: | 150225 | ||||||
| Attachments: |
|
||||||
|
Description
Nicolas Mailhot
2007-01-06 13:06:10 UTC
Where is the behdad's patch? Behdad, did you have a patch for ligatures in firefox ? It's all in my nsFontMetricsPango rewrite that is in FC6. Chris failed to port it previously. I'll start a FF2 build now and see what I can do. *** Bug 236046 has been marked as a duplicate of this bug. *** Has this bug been fixed for Fedora 7? Not yet... Martin can you look at doing the port of this from FC6 (1.5) to FC7 (2.0) ? okay, i'll do that The test case at http://www.gnome.org/~jamesh/firefox-ligature.html looks broken. Is there any other? Testcase is just trying to display text that includes ff or other ligaturable combos with the browser configured (through CSS, etc) to use an opentype font that includes ligatures (like dejavu sans). You can probably ask on #dejavu for people to send you a sample text if the online testcase is dead no problem, i've got one from google cache. Created attachment 158138 [details] backported changes from ff 1.5 There's a backported patch for nsFontMetricsPango class & FF2. A testcase is here: http://people.redhat.com/stransky/ligatures/test.html The patch works fine for me (F7&FF2.0) Can anybody from pango gurus check it? Thanks Martin. Patch looks good. I assume you ported it from the latest FC-6 patch, right? Note the following two lines in fc6's firefox.spec: pushd gfx/src/ps # This sort of sucks, but it works for now. ln -s ../gtk/nsFontMetricsPango.h . ln -s ../gtk/nsFontMetricsPango.cpp . ln -s ../gtk/mozilla-decoder.h . ln -s ../gtk/mozilla-decoder.cpp . popd That is supposed to fix the printing to use Pango. So, please test printing (test some MathML printing to file, before/after). Other than that, got so say Thanks! Can you please port other pango patches too? I see a couple more in FC-6. Finally, all should be applied to thunderbird too. (In reply to comment #13) > Thanks Martin. Patch looks good. I assume you ported it from the latest FC-6 > patch, right? Yep, I used a patch from ff 1.5.0.12 > Note the following two lines in fc6's firefox.spec: > > pushd gfx/src/ps > # This sort of sucks, but it works for now. > ln -s ../gtk/nsFontMetricsPango.h . > ln -s ../gtk/nsFontMetricsPango.cpp . > ln -s ../gtk/mozilla-decoder.h . > ln -s ../gtk/mozilla-decoder.cpp . > popd > > That is supposed to fix the printing to use Pango. So, please test printing > (test some MathML printing to file, before/after). I tested some examples from http://www.mozilla.org/projects/mathml/demo/tester.html the indic examples from Bug 129207 and ligature example and all looks fine. A part of the printing patch was already ported to ff2.0. > Other than that, got so say Thanks! > > Can you please port other pango patches too? I see a couple more in FC-6. Done. These were applied w/o any conflict. Chris - shall I build a ff package and put it into fedora 7 testing? Patches were added to firefox-2.0.0.4-3.fc7 and pushed into testing. firefox-2.0.0.4-3.fc7 has been pushed to the Fedora 7 testing repository. If problems still persist, please make note of it in this bug report. This bug has been fixed in firefox-2.0.0.5-1.fc7 package for Fedora 7. thunderbird-2.0.0.5-2.fc7 has been pushed to the Fedora 7 testing repository. If problems still persist, please make note of it in this bug report. seamonkey-1.1.3-2.fc7 has been pushed to the Fedora 7 stable repository. If problems still persist, please make note of it in this bug report. thunderbird-2.0.0.5-2.fc7 has been pushed to the Fedora 7 stable repository. If problems still persist, please make note of it in this bug report. |