Bug 2217227
| Summary: | Review Request: box64 - Linux userspace x86_64 emulator with a twist, targeted at ARM64 | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Davide Cavalca <davide> |
| Component: | Package Review | Assignee: | Neal Gompa <ngompa13> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | rawhide | CC: | ngompa13, package-review, ppisar |
| Target Milestone: | --- | Flags: | ngompa13:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2023-08-23 21:04:56 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Davide Cavalca
2023-06-25 08:18:24 UTC
This needs access to x86_64 libraries to actually be useful. The easiest way to get those is to dnf --forcearch=x86_64 --installroot=/path/to/x64root install <packages...> and then set BOX64_LD_LIBRARY_PATH=/path/to/x64root before running box64. Taking this review. Spec review: > Requires(post): %{_sbindir}/update-alternatives > Requires(postun): %{_sbindir}/update-alternatives Why are we using alternatives instead of Provides+Conflicts and "RemovePathPostfixes" stanzas? Example of this: https://code.opensuse.org/package/pagure/blob/master/f/pagure.spec#_218-238 Because I figured may want to have the generic aarch64 version and the platform specific one installed concurrently to compare and contrast (not on Apple Silicon, as you'll need the -asahi one for 16k, but on other platforms). Review notes: * Package complies with Fedora Packaging Guidelines * Package builds and installs * Package licensing is correct and license file is correctly installed * No serious issues from rpmlint PACKAGE APPROVED. The Pagure repository was created at https://src.fedoraproject.org/rpms/box64 FEDORA-2023-79361e1193 has been submitted as an update to Fedora 40. https://bodhi.fedoraproject.org/updates/FEDORA-2023-79361e1193 FEDORA-2023-79361e1193 has been pushed to the Fedora 40 stable repository. If problem still persists, please make note of it in this bug report. FEDORA-2023-afa6e96d44 has been submitted as an update to Fedora 38. https://bodhi.fedoraproject.org/updates/FEDORA-2023-afa6e96d44 FEDORA-2023-b21d4b19cb has been submitted as an update to Fedora 39. https://bodhi.fedoraproject.org/updates/FEDORA-2023-b21d4b19cb FEDORA-2023-b21d4b19cb has been pushed to the Fedora 39 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2023-b21d4b19cb \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-b21d4b19cb See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2023-afa6e96d44 has been pushed to the Fedora 38 stable repository. If problem still persists, please make note of it in this bug report. FEDORA-2023-b21d4b19cb has been pushed to the Fedora 39 stable repository. If problem still persists, please make note of it in this bug report. |