Bug 2217227 - Review Request: box64 - Linux userspace x86_64 emulator with a twist, targeted at ARM64
Summary: Review Request: box64 - Linux userspace x86_64 emulator with a twist, targete...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Neal Gompa
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2023-06-25 08:18 UTC by Davide Cavalca
Modified: 2023-09-15 18:39 UTC (History)
3 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2023-08-23 21:04:56 UTC
Type: ---
Embargoed:
ngompa13: fedora-review+


Attachments (Terms of Use)

Description Davide Cavalca 2023-06-25 08:18:24 UTC
Spec URL: https://dcavalca.fedorapeople.org/review/box64/box64.spec
SRPM URL: https://dcavalca.fedorapeople.org/review/box64/box64-0.2.2-1.fc39.src.rpm

Description:
Box64 lets you run x86_64 Linux programs (such as games) on non-x86_64 Linux
systems, like ARM (host system needs to be 64-bit little-endian).

Fedora Account System Username: dcavalca

Comment 1 Davide Cavalca 2023-06-25 08:21:00 UTC
This needs access to x86_64 libraries to actually be useful. The easiest way to get those is to

dnf --forcearch=x86_64 --installroot=/path/to/x64root install <packages...>

and then set BOX64_LD_LIBRARY_PATH=/path/to/x64root before running box64.

Comment 2 Neal Gompa 2023-06-25 09:06:25 UTC
Taking this review.

Comment 3 Neal Gompa 2023-06-25 09:08:37 UTC
Spec review:

> Requires(post): %{_sbindir}/update-alternatives
> Requires(postun): %{_sbindir}/update-alternatives

Why are we using alternatives instead of Provides+Conflicts and "RemovePathPostfixes" stanzas?

Example of this: https://code.opensuse.org/package/pagure/blob/master/f/pagure.spec#_218-238

Comment 4 Davide Cavalca 2023-06-25 09:33:14 UTC
Because I figured may want to have the generic aarch64 version and the platform specific one installed concurrently to compare and contrast (not on Apple Silicon, as you'll need the -asahi one for 16k, but on other platforms).

Comment 5 Neal Gompa 2023-08-23 19:05:51 UTC
Review notes:

* Package complies with Fedora Packaging Guidelines
* Package builds and installs
* Package licensing is correct and license file is correctly installed
* No serious issues from rpmlint

PACKAGE APPROVED.

Comment 6 Fedora Admin user for bugzilla script actions 2023-08-23 19:37:21 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/box64

Comment 7 Fedora Update System 2023-08-23 21:02:51 UTC
FEDORA-2023-79361e1193 has been submitted as an update to Fedora 40. https://bodhi.fedoraproject.org/updates/FEDORA-2023-79361e1193

Comment 8 Fedora Update System 2023-08-23 21:04:56 UTC
FEDORA-2023-79361e1193 has been pushed to the Fedora 40 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 9 Fedora Update System 2023-08-23 22:19:36 UTC
FEDORA-2023-afa6e96d44 has been submitted as an update to Fedora 38. https://bodhi.fedoraproject.org/updates/FEDORA-2023-afa6e96d44

Comment 10 Fedora Update System 2023-08-23 22:19:58 UTC
FEDORA-2023-b21d4b19cb has been submitted as an update to Fedora 39. https://bodhi.fedoraproject.org/updates/FEDORA-2023-b21d4b19cb

Comment 11 Fedora Update System 2023-08-24 01:24:17 UTC
FEDORA-2023-b21d4b19cb has been pushed to the Fedora 39 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2023-b21d4b19cb \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-b21d4b19cb

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 12 Fedora Update System 2023-08-24 01:31:53 UTC
FEDORA-2023-afa6e96d44 has been pushed to the Fedora 38 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 13 Fedora Update System 2023-09-15 18:39:26 UTC
FEDORA-2023-b21d4b19cb has been pushed to the Fedora 39 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.