Bug 2218044
| Summary: | Review Request: guile-reader - A simple framework for building readers for GNU Guile | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Benson Muite <benson_muite> | ||||
| Component: | Package Review | Assignee: | Tom Rix <trix> | ||||
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||
| Severity: | medium | Docs Contact: | |||||
| Priority: | unspecified | ||||||
| Version: | rawhide | CC: | package-review, trix | ||||
| Target Milestone: | --- | Flags: | trix:
fedora-review+
|
||||
| Target Release: | --- | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Linux | ||||||
| URL: | https://www.nongnu.org/guile-reader/%{name} | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2023-09-15 01:35:19 UTC | Type: | --- | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Bug Depends On: | |||||||
| Bug Blocks: | 2218338 | ||||||
| Attachments: |
|
||||||
|
Description
Benson Muite
2023-06-27 23:02:58 UTC
Copr build: https://copr.fedorainfracloud.org/coprs/build/6119946 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2218044-guile-reader/fedora-rawhide-x86_64/06119946-guile-reader/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. Look pretty good.
Some nits.
Do not to hardcode --with-guilemoduledir=/usr/share/... when %{_datadir}/guile/.. is a little better
Be consistent with the guile.spec, use %define mver 2.0
Thanks. Updated. spec: https://download.copr.fedorainfracloud.org/results/fed500/guile-reader/fedora-39-x86_64/06369413-guile-reader/guile-reader.spec srpm: https://download.copr.fedorainfracloud.org/results/fed500/guile-reader/fedora-39-x86_64/06369413-guile-reader/guile-reader-0.6.3-1.fc39.src.rpm Created attachment 1986987 [details]
The .spec file difference from Copr build 6119946 to 6371756
Copr build: https://copr.fedorainfracloud.org/coprs/build/6371756 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2218044-guile-reader/fedora-rawhide-x86_64/06371756-guile-reader/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. Thanks for the changes Approved. The Pagure repository was created at https://src.fedoraproject.org/rpms/guile-reader Thanks. FEDORA-2023-f3d00b833e has been submitted as an update to Fedora 39. https://bodhi.fedoraproject.org/updates/FEDORA-2023-f3d00b833e FEDORA-2023-95f5709f69 has been submitted as an update to Fedora 38. https://bodhi.fedoraproject.org/updates/FEDORA-2023-95f5709f69 FEDORA-2023-33f402aac4 has been submitted as an update to Fedora 37. https://bodhi.fedoraproject.org/updates/FEDORA-2023-33f402aac4 FEDORA-2023-f3d00b833e has been pushed to the Fedora 39 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2023-f3d00b833e \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-f3d00b833e See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2023-33f402aac4 has been pushed to the Fedora 37 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2023-33f402aac4 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-33f402aac4 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2023-95f5709f69 has been pushed to the Fedora 38 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2023-95f5709f69 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-95f5709f69 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2023-33f402aac4 has been pushed to the Fedora 37 stable repository. If problem still persists, please make note of it in this bug report. FEDORA-2023-95f5709f69 has been pushed to the Fedora 38 stable repository. If problem still persists, please make note of it in this bug report. FEDORA-2023-f3d00b833e has been pushed to the Fedora 39 stable repository. If problem still persists, please make note of it in this bug report. |