spec: https://download.copr.fedorainfracloud.org/results/fed500/guile-reader/fedora-38-x86_64/06119909-guile-reader/guile-reader.spec srpm: https://download.copr.fedorainfracloud.org/results/fed500/guile-reader/fedora-38-x86_64/06119909-guile-reader/guile-reader-0.6.3-1.fc38.src.rpm description: The idea is to make it easy to build procedures that extend Guile’s read procedure. Readers supporting various syntax variants can easily be written, possibly by re-using existing “token readers” of a standard Scheme readers. fas: fed500 Reproducible: Always
Copr build: https://copr.fedorainfracloud.org/coprs/build/6119946 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2218044-guile-reader/fedora-rawhide-x86_64/06119946-guile-reader/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Look pretty good. Some nits. Do not to hardcode --with-guilemoduledir=/usr/share/... when %{_datadir}/guile/.. is a little better Be consistent with the guile.spec, use %define mver 2.0
Thanks. Updated. spec: https://download.copr.fedorainfracloud.org/results/fed500/guile-reader/fedora-39-x86_64/06369413-guile-reader/guile-reader.spec srpm: https://download.copr.fedorainfracloud.org/results/fed500/guile-reader/fedora-39-x86_64/06369413-guile-reader/guile-reader-0.6.3-1.fc39.src.rpm
Created attachment 1986987 [details] The .spec file difference from Copr build 6119946 to 6371756
Copr build: https://copr.fedorainfracloud.org/coprs/build/6371756 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2218044-guile-reader/fedora-rawhide-x86_64/06371756-guile-reader/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Thanks for the changes Approved.
The Pagure repository was created at https://src.fedoraproject.org/rpms/guile-reader
Thanks.
FEDORA-2023-f3d00b833e has been submitted as an update to Fedora 39. https://bodhi.fedoraproject.org/updates/FEDORA-2023-f3d00b833e
FEDORA-2023-95f5709f69 has been submitted as an update to Fedora 38. https://bodhi.fedoraproject.org/updates/FEDORA-2023-95f5709f69
FEDORA-2023-33f402aac4 has been submitted as an update to Fedora 37. https://bodhi.fedoraproject.org/updates/FEDORA-2023-33f402aac4
FEDORA-2023-f3d00b833e has been pushed to the Fedora 39 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2023-f3d00b833e \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-f3d00b833e See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2023-33f402aac4 has been pushed to the Fedora 37 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2023-33f402aac4 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-33f402aac4 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2023-95f5709f69 has been pushed to the Fedora 38 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2023-95f5709f69 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-95f5709f69 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2023-33f402aac4 has been pushed to the Fedora 37 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-2023-95f5709f69 has been pushed to the Fedora 38 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-2023-f3d00b833e has been pushed to the Fedora 39 stable repository. If problem still persists, please make note of it in this bug report.