Bug 2219154
Summary: | Review Request: golang-storj-picobuf - Small replacement for subset of protobuf | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Mikel Olasagasti Uranga <mikel> |
Component: | Package Review | Assignee: | Robert-André Mauchin 🐧 <eclipseo> |
Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | eclipseo, package-review |
Target Milestone: | --- | Flags: | eclipseo:
fedora-review+
|
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | If docs needed, set a value | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2023-07-26 22:06:04 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | |||
Bug Blocks: | 2152775 |
Description
Mikel Olasagasti Uranga
2023-07-02 14:27:50 UTC
> %gocheck -d storj.io/picobuf/internal/sizebench you should put: %gocheck -d internal/sizebench Also you should explain why you skip a test, either network/credentials needed, or a bug report upstream saying X test don't work. Here after investigation, it turns out it was fixed upstream in https://github.com/storj/picobuf/commit/2a1eb9b8853cfa90a5c53f28c1eb832594f84570 for Go >= 1.20 You could backport the patch to your spec: Name: %{goname} Release: %autorelease Summary: Small replacement for subset of protobuf License: MIT URL: %{gourl} Source: %{gosource} Patch: https://github.com/storj/picobuf/commit/2a1eb9b8853cfa90a5c53f28c1eb832594f84570.patch Secondly, in such case, it would be preferable to skip the problematic test only, not the entire directory : # https://github.com/storj/picobuf/commit/2a1eb9b8853cfa90a5c53f28c1eb832594f84570 for test in "TestMessageSize" \ ; do awk -i inplace '/^func.*'"$test"'\(/ { print; print "\tt.Skip(\"disabled failing test\")"; next}1' $(grep -rl $test) done - License ok - Latest version packaged - Builds in mock - No rpmlint errors - Conforms to Go Packaging Guidelines Package approved. I'll let you choose the wy you want to deal with the failing test. Best option would be to patch IMHO. The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-storj-picobuf FEDORA-2023-ddf716f3b9 has been submitted as an update to Fedora 39. https://bodhi.fedoraproject.org/updates/FEDORA-2023-ddf716f3b9 FEDORA-2023-ddf716f3b9 has been pushed to the Fedora 39 stable repository. If problem still persists, please make note of it in this bug report. |