Bug 2219154 - Review Request: golang-storj-picobuf - Small replacement for subset of protobuf
Summary: Review Request: golang-storj-picobuf - Small replacement for subset of protobuf
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Robert-André Mauchin 🐧
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 2152775
TreeView+ depends on / blocked
 
Reported: 2023-07-02 14:27 UTC by Mikel Olasagasti Uranga
Modified: 2023-07-26 22:06 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2023-07-26 22:06:04 UTC
Type: ---
Embargoed:
eclipseo: fedora-review+


Attachments (Terms of Use)

Description Mikel Olasagasti Uranga 2023-07-02 14:27:50 UTC
Spec URL: https://mikel.olasagasti.info/tmp/fedora/golang-storj-picobuf.spec
SRPM URL: https://mikel.olasagasti.info/tmp/fedora/golang-storj-picobuf-0.0.1-1.fc38.src.rpm
Description: Small replacement for subset of protobuf.
Fedora Account System Username: mikelo2

Comment 1 Robert-André Mauchin 🐧 2023-07-26 20:14:37 UTC
> %gocheck -d storj.io/picobuf/internal/sizebench


you should put:

%gocheck -d internal/sizebench


Also you should explain why you skip a test, either network/credentials needed, or a bug report upstream saying X test don't work.

Here after investigation, it turns out it was fixed upstream in https://github.com/storj/picobuf/commit/2a1eb9b8853cfa90a5c53f28c1eb832594f84570 for Go >= 1.20

You could backport the patch to your spec:

Name:           %{goname}
Release:        %autorelease
Summary:        Small replacement for subset of protobuf

License:        MIT
URL:            %{gourl}
Source:         %{gosource}
Patch:          https://github.com/storj/picobuf/commit/2a1eb9b8853cfa90a5c53f28c1eb832594f84570.patch


Secondly, in such case, it would be preferable to skip the problematic test only, not the entire directory :

# https://github.com/storj/picobuf/commit/2a1eb9b8853cfa90a5c53f28c1eb832594f84570
for test in "TestMessageSize" \
; do
awk -i inplace '/^func.*'"$test"'\(/ { print; print "\tt.Skip(\"disabled failing test\")"; next}1' $(grep -rl $test)
done


 - License ok
 - Latest version packaged
 - Builds in mock
 - No rpmlint errors
 - Conforms to Go Packaging Guidelines


Package approved. I'll let you choose the wy you want to deal with the failing test. Best option would be to patch IMHO.

Comment 2 Fedora Admin user for bugzilla script actions 2023-07-26 21:43:57 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-storj-picobuf

Comment 3 Fedora Update System 2023-07-26 22:03:37 UTC
FEDORA-2023-ddf716f3b9 has been submitted as an update to Fedora 39. https://bodhi.fedoraproject.org/updates/FEDORA-2023-ddf716f3b9

Comment 4 Fedora Update System 2023-07-26 22:06:04 UTC
FEDORA-2023-ddf716f3b9 has been pushed to the Fedora 39 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.