Bug 2219159
| Summary: | Review Request: libgedit-gtksourceview - Gedit Technology Source code editing widget | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Yaakov Selkowitz <yselkowi> | ||||
| Component: | Package Review | Assignee: | Kalev Lember <klember> | ||||
| Status: | POST --- | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||
| Severity: | medium | Docs Contact: | |||||
| Priority: | medium | ||||||
| Version: | rawhide | CC: | klember, package-review | ||||
| Target Milestone: | --- | Flags: | klember:
fedora-review+
|
||||
| Target Release: | --- | ||||||
| Hardware: | All | ||||||
| OS: | Linux | ||||||
| URL: | https://gedit-technology.net/ | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | Type: | --- | |||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Bug Depends On: | |||||||
| Bug Blocks: | 2218503 | ||||||
| Attachments: |
|
||||||
|
Description
Yaakov Selkowitz
2023-07-02 15:06:52 UTC
Copr build: https://copr.fedorainfracloud.org/coprs/build/6134128 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2219159-libgedit-gtksourceview/fedora-rawhide-x86_64/06134128-libgedit-gtksourceview/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. Spec URL: https://yselkowitz.fedorapeople.org/libgedit-gtksourceview.spec SRPM URL: https://yselkowitz.fedorapeople.org/libgedit-gtksourceview-299.0.4-1.fc40.src.rpm Description: libgedit-gtksourceview is a library that extends GtkTextView, the standard GTK widget for multiline text editing. This library adds support for syntax highlighting, undo/redo, file loading and saving, search and replace, a completion system, printing, displaying line numbers, and other features typical of a source code editor. Fedora Account System Username: yselkowitz Created attachment 1983447 [details]
The .spec file difference from Copr build 6134128 to 6300140
Copr build: https://copr.fedorainfracloud.org/coprs/build/6300140 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2219159-libgedit-gtksourceview/fedora-rawhide-x86_64/06300140-libgedit-gtksourceview/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. Fedora review libgedit-gtksourceview-299.0.4-1.fc40.src.rpm 2023-08-18
$ rpmlint /var/lib/mock/fedora-rawhide-x86_64/result/*.rpm
=================================================================================== rpmlint session starts ===================================================================================
rpmlint: 2.4.0
configuration:
/usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml
/etc/xdg/rpmlint/fedora-legacy-licenses.toml
/etc/xdg/rpmlint/fedora-spdx-licenses.toml
/etc/xdg/rpmlint/fedora.toml
/etc/xdg/rpmlint/scoring.toml
/etc/xdg/rpmlint/users-groups.toml
/etc/xdg/rpmlint/warn-on-functions.toml
checks: 31, packages: 5
libgedit-gtksourceview.src: W: strange-permission libgedit-gtksourceview.spec 600
==================================================== 5 packages and 0 specfiles checked; 0 errors, 1 warnings, 0 badness; has taken 0.8 s ====================================================
+ OK
! needs attention
+ rpmlint output looks good
+ The package is named according to Fedora packaging guidelines
+ The spec file name matches the base package name.
+ The package meets the Packaging Guidelines
+ The package is licensed with a Fedora approved license and meets the
Licensing Guidelines.
+ The license field in the spec file matches the actual license
+ The license text (LGPL) is included in %license
+ Spec file is written in American English
+ Spec file is legible
+ Upstream sources match the sources in the srpm
SHA512 (libgedit-gtksourceview-299.0.4.tar.xz) = cf264620cbe621b51ac22ce9943b1e5517ac7a4d4300d383f4e24664a757fc98e3d339c07a5e6282247d93ea606eafa5346907516d838aec38aaa301fd18d91e
SHA512 (Download/libgedit-gtksourceview-299.0.4.tar.xz) = cf264620cbe621b51ac22ce9943b1e5517ac7a4d4300d383f4e24664a757fc98e3d339c07a5e6282247d93ea606eafa5346907516d838aec38aaa301fd18d91e
+ Package builds in mock
n/a ExcludeArch bugs filed
+ BuildRequires look sane
+ locale handling
+ Package does not bundle copies of system libraries
n/a Package isn't relocatable
+ Package owns all the directories it creates
+ No duplicate files in %files
+ Permissions are properly set
+ Consistent use of macros
+ The package must contain code or permissible content
n/a Large documentation files should go in -doc subpackage
+ Files marked %doc should not affect the runtime of application
n/a Static libraries should be in -static
+ Development files should be in -devel
+ -devel must require the fully versioned base
+ Packages should not contain libtool .la files
n/a Proper .desktop file handling
+ Doesn't own files or directories already owned by other packages
+ Filenames are valid UTF-8
+ Package does not depend on deprecated packages
APPROVED
|