Bug 2219159 - Review Request: libgedit-gtksourceview - Gedit Technology Source code editing widget
Summary: Review Request: libgedit-gtksourceview - Gedit Technology Source code editing...
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Kalev Lember
QA Contact: Fedora Extras Quality Assurance
URL: https://gedit-technology.net/
Whiteboard:
Depends On:
Blocks: 2218503
TreeView+ depends on / blocked
 
Reported: 2023-07-02 15:06 UTC by Yaakov Selkowitz
Modified: 2023-08-18 12:51 UTC (History)
2 users (show)

Fixed In Version: libgedit-gtksourceview-299.0.4-1.fc39, libgedit-gtksourceview-299.0.4-1.fc40
Clone Of:
Environment:
Last Closed: 2023-08-18 12:51:17 UTC
Type: ---
Embargoed:
klember: fedora-review+


Attachments (Terms of Use)
The .spec file difference from Copr build 6134128 to 6300140 (964 bytes, patch)
2023-08-15 20:42 UTC, Fedora Review Service
no flags Details | Diff

Description Yaakov Selkowitz 2023-07-02 15:06:52 UTC
Spec URL: https://yselkowitz.fedorapeople.org/libgedit-gtksourceview.spec
SRPM URL: https://yselkowitz.fedorapeople.org/libgedit-gtksourceview-299.0.3-1.fc39.src.rpm
Description: libgedit-gtksourceview is a library that extends GtkTextView, the standard GTK widget for multiline text editing. This library adds support for syntax highlighting, undo/redo, file loading and saving, search and replace, a completion system, printing, displaying line numbers, and other features typical of a source code editor.
Fedora Account System Username: yselkowitz

Comment 1 Fedora Review Service 2023-07-02 15:13:49 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/6134128
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2219159-libgedit-gtksourceview/fedora-rawhide-x86_64/06134128-libgedit-gtksourceview/fedora-review/review.txt

Please take a look if any issues were found.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 2 Yaakov Selkowitz 2023-08-15 20:32:02 UTC
Spec URL: https://yselkowitz.fedorapeople.org/libgedit-gtksourceview.spec
SRPM URL: https://yselkowitz.fedorapeople.org/libgedit-gtksourceview-299.0.4-1.fc40.src.rpm
Description: libgedit-gtksourceview is a library that extends GtkTextView, the standard GTK widget for multiline text editing. This library adds support for syntax highlighting, undo/redo, file loading and saving, search and replace, a completion system, printing, displaying line numbers, and other features typical of a source code editor.
Fedora Account System Username: yselkowitz

Comment 3 Fedora Review Service 2023-08-15 20:42:54 UTC
Created attachment 1983447 [details]
The .spec file difference from Copr build 6134128 to 6300140

Comment 4 Fedora Review Service 2023-08-15 20:42:56 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/6300140
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2219159-libgedit-gtksourceview/fedora-rawhide-x86_64/06300140-libgedit-gtksourceview/fedora-review/review.txt

Please take a look if any issues were found.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 5 Kalev Lember 2023-08-17 22:34:43 UTC
Fedora review libgedit-gtksourceview-299.0.4-1.fc40.src.rpm 2023-08-18

$ rpmlint /var/lib/mock/fedora-rawhide-x86_64/result/*.rpm
=================================================================================== rpmlint session starts ===================================================================================
rpmlint: 2.4.0
configuration:
    /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-legacy-licenses.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
checks: 31, packages: 5

libgedit-gtksourceview.src: W: strange-permission libgedit-gtksourceview.spec 600
==================================================== 5 packages and 0 specfiles checked; 0 errors, 1 warnings, 0 badness; has taken 0.8 s ====================================================


+ OK
! needs attention

+ rpmlint output looks good
+ The package is named according to Fedora packaging guidelines
+ The spec file name matches the base package name.
+ The package meets the Packaging Guidelines
+ The package is licensed with a Fedora approved license and meets the
  Licensing Guidelines.
+ The license field in the spec file matches the actual license
+ The license text (LGPL) is included in %license
+ Spec file is written in American English
+ Spec file is legible
+ Upstream sources match the sources in the srpm
  SHA512 (libgedit-gtksourceview-299.0.4.tar.xz) = cf264620cbe621b51ac22ce9943b1e5517ac7a4d4300d383f4e24664a757fc98e3d339c07a5e6282247d93ea606eafa5346907516d838aec38aaa301fd18d91e
  SHA512 (Download/libgedit-gtksourceview-299.0.4.tar.xz) = cf264620cbe621b51ac22ce9943b1e5517ac7a4d4300d383f4e24664a757fc98e3d339c07a5e6282247d93ea606eafa5346907516d838aec38aaa301fd18d91e
+ Package builds in mock
n/a ExcludeArch bugs filed
+ BuildRequires look sane
+ locale handling
+ Package does not bundle copies of system libraries
n/a Package isn't relocatable
+ Package owns all the directories it creates
+ No duplicate files in %files
+ Permissions are properly set
+ Consistent use of macros
+ The package must contain code or permissible content
n/a Large documentation files should go in -doc subpackage
+ Files marked %doc should not affect the runtime of application
n/a Static libraries should be in -static
+ Development files should be in -devel
+ -devel must require the fully versioned base
+ Packages should not contain libtool .la files
n/a Proper .desktop file handling
+ Doesn't own files or directories already owned by other packages
+ Filenames are valid UTF-8
+ Package does not depend on deprecated packages

APPROVED

Comment 6 Fedora Admin user for bugzilla script actions 2023-08-18 06:28:51 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/libgedit-gtksourceview


Note You need to log in before you can comment on or make changes to this bug.