Bug 2219763

Summary:	[SSP] Metrics names don't follow naming conventions
Product:	Container Native Virtualization (CNV)	Reporter:	Assaf Admi <aadmi>
Component:	Metrics	Assignee:	Assaf Admi <aadmi>
Status:	ON_QA ---	QA Contact:	Kedar Bidarkar <kbidarka>
Severity:	medium	Docs Contact:
Priority:	unspecified
Version:	4.14.0	CC:	alitman, dholler, kmajcher, sradco, stirabos
Target Milestone:	---	Keywords:	Reopened
Target Release:	4.14.0
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2023-08-10 12:14:24 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Assaf Admi 2023-07-05 09:05:07 UTC

Description of problem:
The following metrics don't follow metrics naming conventions:
- ssp_operator_reconciling_properly
- total_rejected_vms
- total_restored_common_templates
- kubevirt_ssp_template_validator_up_total
- kubevirt_ssp_operator_up_total

Version-Release number of selected component (if applicable):


How reproducible:
Always

Steps to Reproduce:
1. Go to https://github.com/kubevirt/ssp-operator
2. Search for the mentioned metrics

Actual results:
Metrics names don't follow metrics naming conventions

Expected results:
Metrics names to follow https://github.com/kubevirt/monitoring/blob/main/monitoring-guidelines.md#naming-a-new-kubevirt-metrics.

Additional info:

Comment 1 Assaf Admi 2023-08-08 11:50:03 UTC

Addressed in https://github.com/kubevirt/ssp-operator/pull/643.