Bug 2219763

Summary: [SSP] Metrics names don't follow naming conventions
Product: Container Native Virtualization (CNV) Reporter: Assaf Admi <aadmi>
Component: MetricsAssignee: Assaf Admi <aadmi>
Status: CLOSED ERRATA QA Contact: Akash Kanni <akanni>
Severity: medium Docs Contact:
Priority: unspecified    
Version: 4.14.0CC: akanni, akrgupta, alitman, dholler, kmajcher, sradco, stirabos
Target Milestone: ---Keywords: Reopened
Target Release: 4.14.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2023-11-08 14:05:53 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
kubevirt_ssp_operator_reconcile_succeeded
none
kubevirt_ssp_operator_reconcile_succeeded_aggregated
none
kubevirt_ssp_template_validator_rejected_total
none
kubevirt_ssp_template_validator_rejected_increase
none
kubevirt_ssp_common_templates_restored_total
none
kubevirt_ssp_common_templates_restored_increase
none
kubevirt_ssp_template_validator_up
none
kubevirt_ssp_operator_up none

Description Assaf Admi 2023-07-05 09:05:07 UTC 
Description of problem:
The following metrics don't follow metrics naming conventions:
- ssp_operator_reconciling_properly
- total_rejected_vms
- total_restored_common_templates
- kubevirt_ssp_template_validator_up_total
- kubevirt_ssp_operator_up_total

Version-Release number of selected component (if applicable):


How reproducible:
Always

Steps to Reproduce:
1. Go to https://github.com/kubevirt/ssp-operator
2. Search for the mentioned metrics

Actual results:
Metrics names don't follow metrics naming conventions

Expected results:
Metrics names to follow https://github.com/kubevirt/monitoring/blob/main/monitoring-guidelines.md#naming-a-new-kubevirt-metrics.

Additional info:
Comment 1 Assaf Admi 2023-08-08 11:50:03 UTC 
Addressed in https://github.com/kubevirt/ssp-operator/pull/643.
Comment 2 Akash Kanni 2023-09-13 09:24:08 UTC 
Created attachment 1988589 [details]
kubevirt_ssp_operator_reconcile_succeeded
Comment 3 Akash Kanni 2023-09-13 09:34:30 UTC 
Created attachment 1988590 [details]
kubevirt_ssp_operator_reconcile_succeeded_aggregated
Comment 4 Akash Kanni 2023-09-13 10:32:40 UTC 
Created attachment 1988628 [details]
kubevirt_ssp_template_validator_rejected_total
Comment 5 Akash Kanni 2023-09-13 10:34:45 UTC 
Created attachment 1988630 [details]
kubevirt_ssp_template_validator_rejected_increase
Comment 6 Akash Kanni 2023-09-13 10:36:56 UTC 
Created attachment 1988632 [details]
kubevirt_ssp_common_templates_restored_total
Comment 7 Akash Kanni 2023-09-13 12:08:48 UTC 
Created attachment 1988641 [details]
kubevirt_ssp_common_templates_restored_increase
Comment 8 Akash Kanni 2023-09-13 12:10:37 UTC 
Created attachment 1988642 [details]
kubevirt_ssp_template_validator_up
Comment 9 Akash Kanni 2023-09-13 12:12:09 UTC 
Created attachment 1988643 [details]
kubevirt_ssp_operator_up
Comment 10 Akash Kanni 2023-09-13 12:24:10 UTC 
Verified this bug using cluster version "v4.14.0.rhel9-716"

The changes in metric names for the SSP metrics which are 
mentioned in the problem description of this bug (Bug 2219763)
are working fine.

The old metric name are replaced by respective new metric names as mentioned.
Comment 12 errata-xmlrpc 2023-11-08 14:05:53 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Important: OpenShift Virtualization 4.14.0 Images security and bug fix update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2023:6817