Description of problem: The following metrics don't follow metrics naming conventions: - ssp_operator_reconciling_properly - total_rejected_vms - total_restored_common_templates - kubevirt_ssp_template_validator_up_total - kubevirt_ssp_operator_up_total Version-Release number of selected component (if applicable): How reproducible: Always Steps to Reproduce: 1. Go to https://github.com/kubevirt/ssp-operator 2. Search for the mentioned metrics Actual results: Metrics names don't follow metrics naming conventions Expected results: Metrics names to follow https://github.com/kubevirt/monitoring/blob/main/monitoring-guidelines.md#naming-a-new-kubevirt-metrics. Additional info:
Addressed in https://github.com/kubevirt/ssp-operator/pull/643.
Created attachment 1988589 [details] kubevirt_ssp_operator_reconcile_succeeded
Created attachment 1988590 [details] kubevirt_ssp_operator_reconcile_succeeded_aggregated
Created attachment 1988628 [details] kubevirt_ssp_template_validator_rejected_total
Created attachment 1988630 [details] kubevirt_ssp_template_validator_rejected_increase
Created attachment 1988632 [details] kubevirt_ssp_common_templates_restored_total
Created attachment 1988641 [details] kubevirt_ssp_common_templates_restored_increase
Created attachment 1988642 [details] kubevirt_ssp_template_validator_up
Created attachment 1988643 [details] kubevirt_ssp_operator_up
Verified this bug using cluster version "v4.14.0.rhel9-716" The changes in metric names for the SSP metrics which are mentioned in the problem description of this bug (Bug 2219763) are working fine. The old metric name are replaced by respective new metric names as mentioned.
Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory (Important: OpenShift Virtualization 4.14.0 Images security and bug fix update), and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://access.redhat.com/errata/RHSA-2023:6817