Bug 2219763 - [SSP] Metrics names don't follow naming conventions
Summary: [SSP] Metrics names don't follow naming conventions
Keywords:
Status: ON_QA
Alias: None
Product: Container Native Virtualization (CNV)
Classification: Red Hat
Component: Metrics
Version: 4.14.0
Hardware: Unspecified
OS: Unspecified
unspecified
medium
Target Milestone: ---
: 4.14.0
Assignee: Assaf Admi
QA Contact: Kedar Bidarkar
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2023-07-05 09:05 UTC by Assaf Admi
Modified: 2023-08-10 12:16 UTC (History)
5 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2023-08-10 12:14:24 UTC
Target Upstream Version:
Embargoed:

Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Github kubevirt ssp-operator pull 643 0 None Merged Change metrics names 2023-08-10 12:17:00 UTC
Red Hat Issue Tracker CNV-30668 0 None None None 2023-07-05 09:05:56 UTC

Description Assaf Admi 2023-07-05 09:05:07 UTC 
Description of problem:
The following metrics don't follow metrics naming conventions:
- ssp_operator_reconciling_properly
- total_rejected_vms
- total_restored_common_templates
- kubevirt_ssp_template_validator_up_total
- kubevirt_ssp_operator_up_total

Version-Release number of selected component (if applicable):


How reproducible:
Always

Steps to Reproduce:
1. Go to https://github.com/kubevirt/ssp-operator
2. Search for the mentioned metrics

Actual results:
Metrics names don't follow metrics naming conventions

Expected results:
Metrics names to follow https://github.com/kubevirt/monitoring/blob/main/monitoring-guidelines.md#naming-a-new-kubevirt-metrics.

Additional info:
Comment 1 Assaf Admi 2023-08-08 11:50:03 UTC 
Addressed in https://github.com/kubevirt/ssp-operator/pull/643.
Note You need to log in before you can comment on or make changes to this bug.