Bug 2219960
| Summary: | F39FailsToInstall: Multiple packages built from certbot | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Fedora Fails To Install <fti-bugs> |
| Component: | certbot | Assignee: | Nick Bebout <nb> |
| Status: | CLOSED WORKSFORME | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | rawhide | CC: | anon.amish, certbot-sig, luk.claes, mattias.ellert, nb, thrnciar |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2023-07-17 07:24:09 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 2135404, 2168845 | ||
|
Description
Fedora Fails To Install
2023-07-05 19:03:00 UTC
Hello, Please note that this comment was generated automatically by https://pagure.io/releng/blob/main/f/scripts/ftbfs-fti/follow-policy.py If you feel that this output has mistakes, please open an issue at https://pagure.io/releng/ This package fails to install and maintainers are advised to take one of the following actions: - Fix this bug and close this bugzilla once the update makes it to the repository. (The same script that posted this comment will eventually close this bugzilla when the fixed package reaches the repository, so you don't have to worry about it.) or - Move this bug to ASSIGNED if you plan on fixing this, but simply haven't done so yet. or - Orphan the package if you no longer plan to maintain it. If you do not take one of these actions, the process at https://docs.fedoraproject.org/en-US/fesco/Fails_to_build_from_source_Fails_to_install/#_package_removal_for_long_standing_ftbfs_and_fti_bugs will continue. This package may be orphaned in 7+ weeks. This is the first reminder (step 3) from the policy. Don't hesitate to ask for help on devel.org if you are unsure how to fix this bug. With -Wdefault in check to avoid treating DeprecationWarnings as error and with this patch:
diff --git a/certbot-nginx/certbot_nginx/_internal/tests/parser_obj_test.py b/certbot-nginx/certbot_nginx/_internal/tests/parser_obj_test.py
index 710b63f..305b987 100644
--- a/certbot-nginx/certbot_nginx/_internal/tests/parser_obj_test.py
+++ b/certbot-nginx/certbot_nginx/_internal/tests/parser_obj_test.py
@@ -71,7 +71,7 @@ class ParsingHooksTest(unittest.TestCase):
fake_parser2.should_parse = lambda x: False
# First encountered "match" should parse.
parse_raw([])
- fake_parser1.called_once()
+ fake_parser1.assert_called_once()
fake_parser2.not_called()
fake_parser1.reset_mock()
# "match" that returns False shouldn't parse.
@@ -95,9 +95,9 @@ class ParsingHooksTest(unittest.TestCase):
fake_parser1 = mock.Mock()
fake_parser1.should_parse = lambda x: True
parse_raw([])
- fake_parser1.parse.called_with([None])
+ fake_parser1.parse.assert_called_with([None])
parse_raw([], add_spaces=True)
- fake_parser1.parse.called_with([None, True])
+ fake_parser1.parse.assert_called_with([None, True])
class SentenceTest(unittest.TestCase):
diff --git a/certbot/certbot/_internal/tests/renewupdater_test.py b/certbot/certbot/_internal/tests/renewupdater_test.py
index eab07cd..5a6a2cf 100644
--- a/certbot/certbot/_internal/tests/renewupdater_test.py
+++ b/certbot/certbot/_internal/tests/renewupdater_test.py
@@ -47,7 +47,7 @@ class RenewUpdaterTest(test_util.ConfigTestCase):
lineage = mock.MagicMock()
mock_deployer = self.renew_deployer
updater.run_renewal_deployer(self.config, lineage, mock_deployer)
- assert mock_deployer.renew_deploy.called_with(lineage)
+ assert mock_deployer.renew_deploy.assert_called_with(lineage)
@mock.patch("certbot._internal.updater.logger.debug")
def test_updater_skip_dry_run(self, mock_log):
--
2.40.1
I am getting this error:
=================================== FAILURES ===================================
_____________________ RenewUpdaterTest.test_renew_deployer _____________________
self = <certbot._internal.tests.renewupdater_test.RenewUpdaterTest testMethod=test_renew_deployer>
def test_renew_deployer(self):
lineage = mock.MagicMock()
mock_deployer = self.renew_deployer
updater.run_renewal_deployer(self.config, lineage, mock_deployer)
> assert mock_deployer.renew_deploy.assert_called_with(lineage)
E AssertionError: assert None
E + where None = <bound method NonCallableMock.assert_called_with of <MagicMock name='mock.renew_deploy' id='140148396127056'>>(<MagicMock id='140148392771504'>)
E + where <bound method NonCallableMock.assert_called_with of <MagicMock name='mock.renew_deploy' id='140148396127056'>> = <MagicMock name='mock.renew_deploy' id='140148396127056'>.assert_called_with
E + where <MagicMock name='mock.renew_deploy' id='140148396127056'> = <MagicMock spec='RenewDeployer' id='140148392142288'>.renew_deploy
certbot/_internal/tests/renewupdater_test.py:50: AssertionError
Hello, Please note that this comment was generated automatically by https://pagure.io/releng/blob/main/f/scripts/ftbfs-fti/follow-policy.py If you feel that this output has mistakes, please open an issue at https://pagure.io/releng/ All subpackages of a package against which this bug was filled are now installable or removed from Fedora 39. Thanks for taking care of it! |