Bug 2220551

Note to self: restore the test dependency on python-uvloop in python-asyncpg when this issue is closed.

https://github.com/MagicStack/uvloop/issues/547

Hello,

Please note that this comment was generated automatically by https://pagure.io/releng/blob/main/f/scripts/ftbfs-fti/follow-policy.py
If you feel that this output has mistakes, please open an issue at https://pagure.io/releng/

This package fails to install and maintainers are advised to take one of the following actions:

 - Fix this bug and close this bugzilla once the update makes it to the repository.
   (The same script that posted this comment will eventually close this bugzilla
   when the fixed package reaches the repository, so you don't have to worry about it.)

or

 - Move this bug to ASSIGNED if you plan on fixing this, but simply haven't done so yet.

or

 - Orphan the package if you no longer plan to maintain it.


If you do not take one of these actions, the process at https://docs.fedoraproject.org/en-US/fesco/Fails_to_build_from_source_Fails_to_install/#_package_removal_for_long_standing_ftbfs_and_fti_bugs will continue.
This package may be orphaned in 7+ weeks.
This is the first reminder (step 3) from the policy.

Don't hesitate to ask for help on devel.org if you are unsure how to fix this bug.

Hello,

Please note that this comment was generated automatically by https://pagure.io/releng/blob/main/f/scripts/ftbfs-fti/follow-policy.py
If you feel that this output has mistakes, please open an issue at https://pagure.io/releng/

This package fails to install and maintainers are advised to take one of the following actions:

 - Fix this bug and close this bugzilla once the update makes it to the repository.
   (The same script that posted this comment will eventually close this bugzilla
   when the fixed package reaches the repository, so you don't have to worry about it.)

or

 - Move this bug to ASSIGNED if you plan on fixing this, but simply haven't done so yet.

or

 - Orphan the package if you no longer plan to maintain it.


If you do not take one of these actions, the process at https://docs.fedoraproject.org/en-US/fesco/Fails_to_build_from_source_Fails_to_install/#_package_removal_for_long_standing_ftbfs_and_fti_bugs will continue.
This package may be orphaned in 4+ weeks.
This is the second reminder (step 4) from the policy.

Don't hesitate to ask for help on https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org/ if you are unsure how to fix this bug.

This bug appears to have been reported against 'rawhide' during the Fedora Linux 39 development cycle.
Changing version to 39.

This package has changed maintainer in Fedora. Reassigning to the new maintainer of this component.

Hello,

Please note that this comment was generated automatically by https://pagure.io/releng/blob/main/f/scripts/ftbfs-fti/follow-policy.py
If you feel that this output has mistakes, please open an issue at https://pagure.io/releng/

This package fails to install and maintainers are advised to take one of the following actions:

 - Fix this bug and close this bugzilla once the update makes it to the repository.
   (The same script that posted this comment will eventually close this bugzilla
   when the fixed package reaches the repository, so you don't have to worry about it.)

or

 - Move this bug to ASSIGNED if you plan on fixing this, but simply haven't done so yet.

or

 - Orphan the package if you no longer plan to maintain it.


If you do not take one of these actions, the process at https://docs.fedoraproject.org/en-US/fesco/Fails_to_build_from_source_Fails_to_install/#_package_removal_for_long_standing_ftbfs_and_fti_bugs will continue.
This package may be orphaned in 7+ weeks.
This is the first reminder (step 3) from the policy.

Don't hesitate to ask for help on https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org/ if you are unsure how to fix this bug.

This package has changed maintainer in Fedora. Reassigning to the new maintainer of this component.

Hello,

Please note that this comment was generated automatically by https://pagure.io/releng/blob/main/f/scripts/ftbfs-fti/follow-policy.py
If you feel that this output has mistakes, please open an issue at https://pagure.io/releng/

This package fails to install and maintainers are advised to take one of the following actions:

 - Fix this bug and close this bugzilla once the update makes it to the repository.
   (The same script that posted this comment will eventually close this bugzilla
   when the fixed package reaches the repository, so you don't have to worry about it.)

or

 - Move this bug to ASSIGNED if you plan on fixing this, but simply haven't done so yet.

or

 - Orphan the package if you no longer plan to maintain it.


If you do not take one of these actions, the process at https://docs.fedoraproject.org/en-US/fesco/Fails_to_build_from_source_Fails_to_install/#_package_removal_for_long_standing_ftbfs_and_fti_bugs will continue.
This package may be orphaned in 7+ weeks.
This is the first reminder (step 3) from the policy.

Don't hesitate to ask for help on https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org/ if you are unsure how to fix this bug.

I've been looking into this build failure because this package is blocking rebuilding python-uvicorn for Python 3.12.  Upstream this software is not yet compatible with Cython 3.  As a temporary fix, we can set an upper limit on that dependency to get the compatibility package.

-BuildRequires:  python3-Cython
+BuildRequires:  python3-cython < 0.30.0

That allows %build to finish, but %check still fails. I tried making a patch to skip only the tests that fail on Python 3.12, but it isn't working correctly and I'm not sure why.

https://github.com/carlwgeorge/uvloop/commit/952099791a9144081d9e8eec21ccbbeae0a1c591

One alternative would be to just disable the tests entirely on F39/F40 until upstream can sort out their Python 3.12 compatibility.

  @unittest.skipIf(sys.version_info < (3, 12), "test fails on Python 3.12")

This should probably be:

  @unittest.skipIf(sys.version_info >= (3, 12), "test fails on Python 3.12")

There's also

  # for pyximport on Cyhton 0.29:
  BuildRequires:  python3-zombie-imp

But I end up with:

ERROR: test_libuv_get_loop_t_ptr (tests.test_libuv_api.Test_UV_libuv.test_libuv_get_loop_t_ptr)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/builddir/build/BUILD/uvloop-0.17.0/tests/test_libuv_api.py", line 16, in test_libuv_get_loop_t_ptr
    import cython_helper
ModuleNotFoundError: No module named 'cython_helper'

Anyway.

I tried a bigger hammer, by just deleting the files that have non-working tests.

https://src.fedoraproject.org/rpms/python-uvloop/pull-request/6

FEDORA-2023-5967d3ecde has been submitted as an update to Fedora 40. https://bodhi.fedoraproject.org/updates/FEDORA-2023-5967d3ecde

FEDORA-2023-5967d3ecde has been pushed to the Fedora 40 stable repository.
If problem still persists, please make note of it in this bug report.

FEDORA-2023-ae19f823c9 has been submitted as an update to Fedora 39. https://bodhi.fedoraproject.org/updates/FEDORA-2023-ae19f823c9

I am not gonna block this, but note that I have some trouble reenabling the [uvloop] extra in black:

https://src.fedoraproject.org/rpms/python-black/pull-request/27
https://src.fedoraproject.org/rpms/python-black/pull-request/28


/usr/lib/python3.12/unittest/async_case.py:133: in run
    self._tearDownAsyncioRunner()
/usr/lib/python3.12/unittest/async_case.py:126: in _tearDownAsyncioRunner
    runner.close()
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
self = <asyncio.runners.Runner object at 0xf3264630>
    def close(self):
        """Shutdown and close event loop."""
        if self._state is not _State.INITIALIZED:
            return
        try:
            loop = self._loop
            _cancel_all_tasks(loop)
            loop.run_until_complete(loop.shutdown_asyncgens())
            loop.run_until_complete(
>               loop.shutdown_default_executor(constants.THREAD_JOIN_TIMEOUT))
E               TypeError: Loop.shutdown_default_executor() takes no arguments (1 given)
/usr/lib/python3.12/asyncio/runners.py:73: TypeError


(Updating black to the latest version did not help.)

(In reply to Ben Beasley from comment #1)
> Note to self: restore the test dependency on python-uvloop in python-asyncpg
> when this issue is closed.

This works for me in F40/Rawhide now.

FEDORA-2023-ae19f823c9 has been pushed to the Fedora 39 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2023-ae19f823c9`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-ae19f823c9

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

+3 in https://pagure.io/fedora-qa/blocker-review/issue/1364 , marking accepted.

FEDORA-2023-ae19f823c9 has been pushed to the Fedora 39 stable repository.
If problem still persists, please make note of it in this bug report.