Bug 2221358
| Summary: | Review Request: rust-rpds - Persistent data structures with structural sharing | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Mattia Verga <mattia.verga> |
| Component: | Package Review | Assignee: | Fabio Valentini <decathorpe> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | decathorpe, package-review |
| Target Milestone: | --- | Flags: | decathorpe:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2023-07-11 18:48:57 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 2221357 | ||
| Bug Blocks: | 2179260 | ||
|
Description
Mattia Verga
2023-07-08 09:41:05 UTC
This package depends on rust-archery (RHBZ#2221357), which I've just reviewed. I'll continue this review once it's been imported and built for rawhide. PS: If you hadn't noticed the FTI issue, I recommend using the "--postinstall" flag for local mock builds. (Same comment about using "rust2rpm -p" for patching Cargo.toml applies here.) Reworked specfile with "rust2rpm -p" BTW, as I'm new to rust packaging, shouldn't the `BuildArch: noarch` tag be set on the main package? We are building the package for all arches and then provide only noarch rpms... Thanks, will review later! Not having "BuildArch: no arch" apply to the whole package is intentional because we want to test build / run tests on all architectures. Package was generated with rust2rpm, simplifying the review. - package builds and installs without errors on rawhide - test suite is run and all unit tests pass - latest version of the crate is packaged - license matches upstream specification (MPL-2.0) and is acceptable for Fedora - license file is included with %license in %files - package complies with Rust Packaging Guidelines Package APPROVED. === Recommended post-import rust-sig tasks: - set up package on release-monitoring.org: project: $crate homepage: https://crates.io/crates/$crate backend: crates.io version scheme: semantic version filter: alpha;beta;rc;pre distro: Fedora Package: rust-$crate - add @rust-sig with "commit" access as package co-maintainer (should happen automatically) - set bugzilla assignee overrides to @rust-sig (optional) - track package in koschei for all built branches (should happen automatically once rust-sig is co-maintainer) If you need help with packaging "Rusty" Python packages, feel free to reach out. Both python-orjson and python-y-py are good examples for such packages, if you want to take a stab at it yourself. (In reply to Fabio Valentini from comment #6) > If you need help with packaging "Rusty" Python packages, feel free to reach > out. > Both python-orjson and python-y-py are good examples for such packages, if > you want to take a stab at it yourself. Yes thanks, I already used them to write down a specfile for rpds-py and it was my intention to ask in some ML to add those examples to Packaging Guidelines for easier reference. The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-rpds FEDORA-2023-e4afea439c has been submitted as an update to Fedora 39. https://bodhi.fedoraproject.org/updates/FEDORA-2023-e4afea439c FEDORA-2023-e4afea439c has been pushed to the Fedora 39 stable repository. If problem still persists, please make note of it in this bug report. |