Bug 2221358 - Review Request: rust-rpds - Persistent data structures with structural sharing
Summary: Review Request: rust-rpds - Persistent data structures with structural sharing
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Fabio Valentini
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: 2221357
Blocks: 2179260
TreeView+ depends on / blocked
 
Reported: 2023-07-08 09:41 UTC by Mattia Verga
Modified: 2023-07-11 18:48 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2023-07-11 18:48:57 UTC
Type: ---
Embargoed:
decathorpe: fedora-review+


Attachments (Terms of Use)

Description Mattia Verga 2023-07-08 09:41:05 UTC
Spec URL: https://mattia.fedorapeople.org/rust-rpds/rust-rpds.spec
SRPM URL: https://mattia.fedorapeople.org/rust-rpds/rust-rpds-0.13.0-1.fc39.src.rpm
Description: Persistent data structures with structural sharing
Fedora Account System Username: mattia

Comment 1 Fabio Valentini 2023-07-08 09:55:03 UTC
This package depends on rust-archery (RHBZ#2221357), which I've just reviewed.
I'll continue this review once it's been imported and built for rawhide.
PS: If you hadn't noticed the FTI issue, I recommend using the "--postinstall" flag for local mock builds.

Comment 2 Fabio Valentini 2023-07-08 09:55:55 UTC
(Same comment about using "rust2rpm -p" for patching Cargo.toml applies here.)

Comment 3 Mattia Verga 2023-07-08 12:02:44 UTC
Reworked specfile with "rust2rpm -p"

BTW, as I'm new to rust packaging, shouldn't the `BuildArch: noarch` tag be set on the main package? We are building the package for all arches and then provide only noarch rpms...

Comment 4 Fabio Valentini 2023-07-08 12:07:40 UTC
Thanks, will review later!

Not having "BuildArch: no arch" apply to the whole package is intentional because we want to test build / run tests on all architectures.

Comment 5 Fabio Valentini 2023-07-11 15:18:02 UTC
Package was generated with rust2rpm, simplifying the review.

- package builds and installs without errors on rawhide
- test suite is run and all unit tests pass
- latest version of the crate is packaged
- license matches upstream specification (MPL-2.0) and is acceptable for Fedora
- license file is included with %license in %files
- package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks:

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version filter: alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- add @rust-sig with "commit" access as package co-maintainer
  (should happen automatically)

- set bugzilla assignee overrides to @rust-sig (optional)

- track package in koschei for all built branches
  (should happen automatically once rust-sig is co-maintainer)

Comment 6 Fabio Valentini 2023-07-11 15:21:17 UTC
If you need help with packaging "Rusty" Python packages, feel free to reach out.
Both python-orjson and python-y-py are good examples for such packages, if you want to take a stab at it yourself.

Comment 7 Mattia Verga 2023-07-11 18:20:52 UTC
(In reply to Fabio Valentini from comment #6)
> If you need help with packaging "Rusty" Python packages, feel free to reach
> out.
> Both python-orjson and python-y-py are good examples for such packages, if
> you want to take a stab at it yourself.

Yes thanks, I already used them to write down a specfile for rpds-py and it was my intention to ask in some ML to add those examples to Packaging Guidelines for easier reference.

Comment 8 Fedora Admin user for bugzilla script actions 2023-07-11 18:22:49 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-rpds

Comment 9 Fedora Update System 2023-07-11 18:47:28 UTC
FEDORA-2023-e4afea439c has been submitted as an update to Fedora 39. https://bodhi.fedoraproject.org/updates/FEDORA-2023-e4afea439c

Comment 10 Fedora Update System 2023-07-11 18:48:57 UTC
FEDORA-2023-e4afea439c has been pushed to the Fedora 39 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.