Bug 2222455

Summary: check_log fills /tmp and contains debug statement
Product: [Fedora] Fedora EPEL Reporter: christopher.gefvert
Component: nagios-pluginsAssignee: Guido Aulisi <guido.aulisi>
Status: NEW --- QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: unspecified    
Version: epel9CC: guido.aulisi, herrold, igor.raits, lemenkov, ondrejj, smooge, xavier
Target Milestone: ---   
Target Release: ---   
Hardware: x86_64   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description christopher.gefvert 2023-07-12 20:03:41 UTC
Description of problem:

1)

Starting with version 2.4.4 the plugin script check_log creates $templog    ${TMPDIR}/temp_check_log.XXXXXXXXXX     starting at line 214.

This temp file is copied to from the target log like /var/log/messages.

cp "$logfile" "$templog"
logfile=$templog

And used for a diff.

diff "$logfile" "$oldlog" | grep -v "^>" > "$tempdiff"

After getting what’s needed, $tempdiff is cleaned up and $oldlog replaced.

rm -f "$tempdiff"
cat "$logfile" > "$oldlog"

This leaves the temp file      $logfile    ${TMPDIR}/temp_check_log.XXXXXXXXXX       behind which has been filling my /tmp folders.   If I missed something let me know, but I suspect this temp file, new in 2.4.4 should be deleted after the cat.  Or change the cat to mv.


2) 

Also check_log v2.4.4 line 209….

echo "$TMPDIR"

…trips up the GUI display.  Looks like a testing comment that needs to be removed.




Version-Release number of selected component (if applicable): 

nagios-plugins-log.x86_64  2.4.4-1.el9


How reproducible: 

/usr/lib64/nagios/plugins/check_log   -F /var/log/messages -O /tmp/messages.nagios -q NOTICE



Steps to Reproduce:
1.
2.
3.

Actual results:



Expected results:


Additional info:

Comment 1 Jan ONDREJ 2023-07-20 06:25:00 UTC
If this is a check_log nagios plugin problem, why this bug is filled against nrpe? It's a different package. Reassinging to nagios-plugins.